| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: nodejs#2507
Sorry, something went wrong.
|
@ofrobots we have cherry-picked several commits into master. Do you think it might be useful to put them in this PR too? |
Sorry, something went wrong.
|
@indutny this PR is an application of the patches from 4.5.103.30...4.5.103.33 rather than a replacement of deps/v8 code. This should preserve the cherry-picks being floated by Node (unless they are in negation of the patch arriving from upstream.) You can browse the tree here https://github.com/ofrobots/node/tree/4.5.103.33 to verify that the cherry-picks are still there. |
Sorry, something went wrong.
|
Oh, true! Sorry about this. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
CI is good, LGTM |
Sorry, something went wrong.
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: #2507 PR-URL: #2870 Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thanks. Landed on master in 704dcce. |
Sorry, something went wrong.
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: #2507 PR-URL: #2870 Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
Notable changes: * buffer: - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) nodejs#2866. - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) nodejs#2777. * fs: - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) nodejs#2387. - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) nodejs#2167. * http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) nodejs#2824. * npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) nodejs#2822. * src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) nodejs#2324. * v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) nodejs#2870. - This fixes a previously known bug where some computed object shorthand properties did not work correctly (nodejs#2507). Refs: nodejs#2844 PR-URL: nodejs#2889
Notable changes: * buffer: - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) #2866. - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) #2777. * fs: - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) #2387. - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) #2167. * http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) #2824. * npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) #2822. * src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) #2324. * v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) #2870. - This fixes a previously known bug where some computed object shorthand properties did not work correctly (#2507). Refs: #2844 PR-URL: #2889
|
landed in lts-v4.x-staging as 7ebd881 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with
computed property names not working in nested literals.
Full V8 4.5 commit log at:
https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5
Fixes: #2507
R=@bnoordhuis
/cc @nodejs/v8