FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x backport] tools: replace rollup with ncc by Trott · Pull Request #28736 · nodejs/node · GitHub

/ node Public

[v10.x backport] tools: replace rollup with ncc - #28736

Closed
Trott wants to merge 1 commit into
nodejs:v10.x-stagingfrom
Trott:backport-24813
ConversationCommits (1)ChecksFiles changed
Closed

[v10.x backport] tools: replace rollup with ncc#28736
Trott wants to merge 1 commit into
nodejs:v10.x-stagingfrom
Trott:backport-24813

Conversation

Trott commented Jul 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Replace rollup + plugins + config file with zeit/ncc package designed to
do the particular task that we're leveraging rollup for but with
zero-ish configuration. (rollup can do a whole lot more, but we're using
a tiny portion of its functionality.)

PR-URL: #24813
Reviewed-By: Guy Bedford guybedford@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

@BethGriggs

Backport of #24813

nodejs-github-bot added tools Issues and PRs related to the tools directory. v10.x labels Jul 17, 2019

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
tools: replace rollup with ncc
3ebdd0d 
Replace rollup + plugins + config file with zeit/ncc package designed to
do the particular task that we're leveraging rollup for but with
zero-ish configuration. (rollup can do a whole lot more, but we're using
a tiny portion of its functionality.)

PR-URL: nodejs#24813
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: nodejs#28736

Trott commented Jul 17, 2019

Copy link
Copy Markdown
Member Author

OK, fixed. (I should have done an npm ci before rebuilding lint-md.js and now I have and everything seems OK.) Will re-run CI...

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jul 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24555/

nodejs-github-bot commented Jul 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24586/

nodejs-github-bot commented Jul 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24594/

nodejs-github-bot commented Jul 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24597/

nodejs-github-bot commented Jul 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24600/

Trott commented Jul 21, 2019

Copy link
Copy Markdown
Member Author

The persistent AIX CI failures are surely unrelated and I guess suggest that there's some fix for AIX on master that has not yet landed on v10.x-staging? /ping @nodejs/platform-aix

richardlau commented Jul 21, 2019

Copy link
Copy Markdown
Member

The persistent AIX CI failures are surely unrelated and I guess suggest that there's some fix for AIX on master that has not yet landed on v10.x-staging? /ping @nodejs/platform-aix

At least #28600 hasn’t made it back yet.

Trott commented Jul 25, 2019

Copy link
Copy Markdown
Member Author

CI will be red on this until #28826 lands, but then this should be good to go.

nodejs-github-bot commented Jul 25, 2019 •
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24703/ ✅

BethGriggs pushed a commit that referenced this pull request Jul 25, 2019
tools: replace rollup with ncc
4a607fa 
Replace rollup + plugins + config file with zeit/ncc package designed to
do the particular task that we're leveraging rollup for but with
zero-ish configuration. (rollup can do a whole lot more, but we're using
a tiny portion of its functionality.)

PR-URL: #24813
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: #28736

BethGriggs commented Jul 25, 2019

Copy link
Copy Markdown
Member

Landed on v10.x-staging

BethGriggs closed this Jul 25, 2019
Trott deleted the backport-24813 branch January 13, 2022 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL