FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: generate openssl config for BSD-x86 by bnoordhuis · Pull Request #28806 · nodejs/node · GitHub

/ node Public

build: generate openssl config for BSD-x86 - #28806

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix20326
ConversationCommits (1)ChecksFiles changed
Closed

build: generate openssl config for BSD-x86#28806
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix20326

Conversation

bnoordhuis commented Jul 22, 2019

Copy link
Copy Markdown
Member

Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: #20326

build: generate openssl config for BSD-x86
23501ed 
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: nodejs#20326
nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Jul 22, 2019

nodejs-github-bot commented Jul 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24613/

bnoordhuis mentioned this pull request Jul 22, 2019
Closed

nodejs-github-bot commented Jul 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24666/

Trott approved these changes Jul 24, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

Trott commented Jul 24, 2019

Copy link
Copy Markdown
Member

@nodejs/crypto

Trott commented Jul 25, 2019

Copy link
Copy Markdown
Member

@nodejs/platform-freebsd

bnoordhuis added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 25, 2019

sam-github commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

@bradleythughes

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

Technically, this can land (1 approval, more than 7 days open, passing CI) but another review would be nice, especially if it's a little more thorough than my rubber-stamp. @nodejs/collaborators

lpinca approved these changes Jul 30, 2019
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

emaste commented Jul 30, 2019

Copy link
Copy Markdown

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 30, 2019
build: generate openssl config for BSD-x86
4a1502b 
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: nodejs#20326

PR-URL: nodejs#28806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

Landed in 4a1502b. node-core-utils said it fixed whitespace errors during a git am so I'm going to manually start a node-daily-master to make sure this didn't introduce errors, or at least not any errors that would trip our tests. https://ci.nodejs.org/job/node-daily-master/1629/

Trott closed this Jul 30, 2019

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

(node-daily-master is green.)

targos pushed a commit that referenced this pull request Aug 2, 2019
build: generate openssl config for BSD-x86
25aa222 
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: #20326

PR-URL: #28806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Aug 6, 2019
Merged
bnoordhuis deleted the fix20326 branch August 15, 2019 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BSD-x86 config missing after OpenSSL 1.1.0h import

6 participants

Back | FazBrowse Home | New Git URL