doc: writableFinished is true before 'finish' - #28811
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Practically, I"m not sure what the difference is to the reader? Is this about what finished is set to when your finish event listener runs or something like that? |
Sorry, something went wrong.
ronag
force-pushed
the
fix-docs-writableFinished
branch
from
459e4ad to
d3b065b
Compare
July 23, 2019 05:29
Copy link
Copy Markdown
Member
Author
|
It’s important in order to know whether when I register a finish listener if it will be called or not. |
Sorry, something went wrong.
ronag
force-pushed
the
fix-docs-writableFinished
branch
from
d3b065b to
2502502
Compare
July 23, 2019 07:53
Comment thread
doc/api/http.md
Outdated
ronag
force-pushed
the
fix-docs-writableFinished
branch
from
2502502 to
cc13c69
Compare
July 23, 2019 10:16
sam-github
reviewed
Jul 23, 2019
Comment thread
doc/api/http.md
Outdated
ronag
force-pushed
the
fix-docs-writableFinished
branch
2 times, most recently
from
5998562 to
0b677a6
Compare
July 23, 2019 20:50
Trott
approved these changes
Jul 23, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/streams |
Sorry, something went wrong.
mcollina
requested changes
Jul 26, 2019
Comment thread
doc/api/http.md
Outdated
ronag
force-pushed
the
fix-docs-writableFinished
branch
from
0b677a6 to
c3b6f5b
Compare
August 2, 2019 06:34
ronag
force-pushed
the
fix-docs-writableFinished
branch
from
c3b6f5b to
204b76b
Compare
August 2, 2019 06:35
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
reviewed
Aug 2, 2019
Comment thread
doc/api/http.md
mcollina
approved these changes
Aug 2, 2019
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2019
PR-URL: nodejs#28811 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28811 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description for stream.writableFinished is not entirely correct.
Checklist