Build static libnode_internal to avoid cyclic dependency on mkcodecache - #28891
Closed
jeroen wants to merge 2 commits into
Closed
Build static libnode_internal to avoid cyclic dependency on mkcodecache#28891jeroen wants to merge 2 commits into
jeroen wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
devsnek
reviewed
Jul 31, 2019
Comment thread
node.gyp
| 'NODE_OPENSSL_SYSTEM_CERT_PATH=""', | ||
| ], | ||
|
|
||
| 'sources': [ |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
is this list duplicated now?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The bug #27431 has already been fixed via a more simple solution in #28897. Ideally a rewrite of the build as above would probably be better so that we get the same cached symbols when calling libnode from a 3rd party application as in node itself. However this is just a small performance gain and for my purposes the workaround from #28897 suffices. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a first draft to fix #27431 by implementing exactly this:
node/node.gyp
Lines 1161 to 1166 in 62a809f
The problem here is that the libnode shared library is missing the code cache symbols because of the cyclical dependency between libnode and mkcodecache in node.gyp.
We need to build mkcodecache to generate node_code_cache.cc. However currently mkcodecache itself depends on libnode so we cannot include the generated symbols to libnode. In the current setup node_code_cache.cc is linked when building node.exe but when building node as a shared library the symbols are missing libnode, which causes the issues in #27431.
The solution is described comment above: modify the mkcodecache build such that it does not depend on the full libnode, but instead on a smaller libnode_internal which suffices to generate the cache symbols. And then we can include node_code_cache.cc in libnode.so.
Checklist