test: refactoring test_error testing - #28902
Closed
himself65 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
himself65
force-pushed
the
refactor-test_error
branch
from
db6b9c8 to
1e30a0c
Compare
July 30, 2019 18:19
lpinca
approved these changes
Jul 30, 2019
Comment thread
test/js-native-api/test_error/test.js
Outdated
himself65
force-pushed
the
refactor-test_error
branch
from
1e30a0c to
a3af754
Compare
July 30, 2019 19:14
cjihrig
approved these changes
Jul 30, 2019
ZYSzys
approved these changes
Jul 31, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
Jul 31, 2019
trivikr
approved these changes
Jul 31, 2019
Trott
approved these changes
Aug 1, 2019
Copy link
Copy Markdown
Member
|
LGTM, but at the same time, I kinda wonder if the current format is more readable/maintainable TBH. |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 1, 2019
PR-URL: nodejs#28902 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28902 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist