http2: destroy when call settingsFn throw an error - #28908
Closed
himself65 wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Jul 31, 2019
Comment thread
test/parallel/test-http2-connect.js
Outdated
himself65
force-pushed
the
28895
branch
6 times, most recently
from
52cde56 to
f8371b2
Compare
August 1, 2019 06:50
Copy link
Copy Markdown
Member
Author
|
done |
Sorry, something went wrong.
trivikr
approved these changes
Aug 1, 2019
jasnell
approved these changes
Aug 1, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Aug 2, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2019
http2.connect should call destroy when init fails. PR-URL: nodejs#28908 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
http2.connect should call destroy when init fails. PR-URL: #28908 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #28895
Checklist