FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor test-fs-stat.js by Trott · Pull Request #28929 · nodejs/node · GitHub

/ node Public

test: refactor test-fs-stat.js - #28929

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:refactor-test-fs-stat
Aug 3, 2019
Merged

test: refactor test-fs-stat.js#28929
Trott merged 1 commit into
nodejs:masterfrom
Trott:refactor-test-fs-stat

Conversation

Trott commented Aug 1, 2019

Copy link
Copy Markdown
Member

General code cleanup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 1, 2019
addaleax added the fs Issues and PRs related to the fs subsystem / file system. label Aug 1, 2019

Copy link
Copy Markdown
Collaborator

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 2, 2019

Copy link
Copy Markdown
Collaborator

General code cleanup.

PR-URL: nodejs#28929
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott force-pushed the refactor-test-fs-stat branch from 8d771f1 to e6c2052 Compare August 3, 2019 23:11

Trott commented Aug 3, 2019

Copy link
Copy Markdown
Member Author

Landed in e6c2052

Trott merged commit e6c2052 into nodejs:master Aug 3, 2019
BridgeAR pushed a commit that referenced this pull request Aug 6, 2019
General code cleanup.

PR-URL: #28929
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott deleted the refactor-test-fs-stat branch January 13, 2022 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL