FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: improve debuglog performance by mscdex · Pull Request #28956 · nodejs/node · GitHub

/ node Public

util: improve debuglog performance - #28956

Merged
mscdex merged 1 commit into
nodejs:masterfrom
mscdex:debuglog-perf
Aug 9, 2019
ConversationCommits (1)ChecksFiles changed
Merged

util: improve debuglog performance#28956
mscdex merged 1 commit into
nodejs:masterfrom
mscdex:debuglog-perf

Conversation

mscdex commented Aug 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sample results:

 streams/pipe-object-mode.js n=5000000                        ***     14.74 %       ±1.49% ±1.99%  ±2.60%
 streams/pipe.js n=5000000                                    ***     14.54 %       ±2.10% ±2.79%  ±3.64%
 streams/readable-bigread.js n=1000                           ***      7.85 %       ±1.15% ±1.53%  ±1.99%
 streams/readable-boundaryread.js type='buffer' n=2000        ***     28.70 %       ±1.95% ±2.60%  ±3.40%
 streams/readable-boundaryread.js type='string' n=2000        ***      6.98 %       ±1.55% ±2.07%  ±2.70%
 streams/readable-readall.js n=5000                           ***      7.49 %       ±1.61% ±2.14%  ±2.79%
 streams/readable-unevenread.js n=1000                        ***      9.55 %       ±1.41% ±1.87%  ±2.44%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

mscdex added util Issues and PRs related to the built-in util module. performance Issues and PRs related to the performance of Node.js. labels Aug 4, 2019

nodejs-github-bot commented Aug 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24841/

util: improve debuglog performance
ef01d7c 
PR-URL: nodejs#28956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mscdex merged commit ef01d7c into nodejs:master Aug 9, 2019
mscdex deleted the debuglog-perf branch August 9, 2019 22:20
targos pushed a commit that referenced this pull request Aug 19, 2019
util: improve debuglog performance
a4e2549 
PR-URL: #28956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes
trivikr trivikr approved these changes
+3 more reviewers
antsmartian antsmartian approved these changes
targos targos approved these changes
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

performance Issues and PRs related to the performance of Node.js. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL