report: list envvars using uv_os_environ() - #28963
Merged
cjihrig merged 1 commit intoAug 11, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
saghul
approved these changes
Aug 5, 2019
saghul
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
gengjiawen
approved these changes
Aug 5, 2019
addaleax
approved these changes
Aug 5, 2019
Comment thread
src/node_report.cc
Outdated
cjihrig
force-pushed
the
envvars
branch
3 times, most recently
from
8b89159 to
097a154
Compare
August 11, 2019 15:35
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/24939/ EDIT: CI was yellow. |
Sorry, something went wrong.
This commit simplifies the diagnostic report's code for listing environment variables by using uv_os_environ() instead of platform specific code. PR-URL: nodejs#28963 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
This commit simplifies the diagnostic report's code for listing environment variables by using uv_os_environ() instead of platform specific code. PR-URL: #28963 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is a bit premature. It requires the libuv 1.31.0 update, which will happen later this week. Only the second commit (report: list envvars using uv_os_environ()) is relevant. libuv 1.31.0 includes a new API, uv_os_environ(), for iterating over the environment variables.
This PR simplifies the diagnostic report's code for listing environment variables by using uv_os_environ() instead of platform specific code.
cc: @nodejs/libuv
Checklist