FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: allow easy passing of process flags by mscdex · Pull Request #28986 · nodejs/node · GitHub

/ node Public

benchmark: allow easy passing of process flags - #28986

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:benchmark-prof-feature
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: allow easy passing of process flags#28986
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:benchmark-prof-feature

Conversation

mscdex commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

Without this, using --prof when running benchmarks also produces separate profiler output for the benchmark runner itself, which is generally not helpful. With this change, it's quick and easy to know which profiler output file to look at.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

mscdex added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 5, 2019

nodejs-github-bot commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24850/

nodejs-github-bot commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24855/

mscdex added the wip Issues and PRs that are still a work in progress. label Aug 7, 2019
mscdex force-pushed the benchmark-prof-feature branch from 6dcf3e9 to 4083bbc Compare August 7, 2019 05:30

nodejs-github-bot commented Aug 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24878/

mscdex commented Aug 7, 2019

Copy link
Copy Markdown
Contributor Author

@bnoordhuis @jasnell I've decided to generalize this because the ability to use other flags (e.g. --inspect) will be equally useful. Does this still LGTY?

Trott commented Aug 7, 2019

Copy link
Copy Markdown
Member

Benchmark test run: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8413/ (queued, will 404 until a worker is available)

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 7, 2019
bnoordhuis approved these changes Aug 7, 2019
View reviewed changes
Comment thread benchmark/common.js Outdated

bnoordhuis Aug 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe split on /\s+/? Otherwise env NODE_BENCHMARK_FLAGS="--foo --bar" node bench.js (note the double space) produces three flags, one of them the empty string.

mscdex force-pushed the benchmark-prof-feature branch from 4083bbc to c0358a8 Compare August 7, 2019 13:56
mscdex removed the wip Issues and PRs that are still a work in progress. label Aug 7, 2019

nodejs-github-bot commented Aug 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24883/

mscdex changed the title benchmark: allow easier profiling of benchmarks benchmark: allow easy passing of process flags Aug 7, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 8, 2019
benchmark: allow easy passing of process flags
fd8d44f 
PR-URL: nodejs#28986
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott commented Aug 8, 2019

Copy link
Copy Markdown
Member

Landed in fd8d44f

Trott closed this Aug 8, 2019
mscdex deleted the benchmark-prof-feature branch August 8, 2019 03:13
targos pushed a commit that referenced this pull request Aug 19, 2019
benchmark: allow easy passing of process flags
5008b46 
PR-URL: #28986
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
Trott Trott approved these changes
trivikr trivikr approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL