http: replace superfluous property with getter/setter - #29015
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Aug 6, 2019
Copy link
Copy Markdown
Contributor
|
AFAIK getters/setters like this incur noticeable overhead, so perhaps we should be adjusting the documentation to more strongly recommend socket over connection. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Also if we're making this change we should also replace all usage of .connection in core with .socket to avoid the overhead. |
Sorry, something went wrong.
ronag
force-pushed
the
http-connection
branch
2 times, most recently
from
551d5ec to
9fe52d4
Compare
August 6, 2019 12:51
ronag
force-pushed
the
http-connection
branch
7 times, most recently
from
c16f5f6 to
80a07da
Compare
August 6, 2019 13:56
trivikr
reviewed
Aug 6, 2019
Comment thread
doc/api/deprecations.md
Outdated
Comment thread
doc/api/deprecations.md
Outdated
Comment thread
doc/api/deprecations.md
Outdated
Comment thread
doc/api/deprecations.md
Outdated
jasnell
approved these changes
Aug 7, 2019
trivikr
approved these changes
Aug 7, 2019
lpinca
approved these changes
Aug 9, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Aug 17, 2019
This was referenced Jan 20, 2021
This was referenced Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly reduces memory overhead by replacing superfluous property with getter/setter.
Checklist