http: buffer writes while no socket - #29019
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
force-pushed
the
http-buffer-even-while-no-socket
branch
2 times, most recently
from
7e038a5 to
6cc9e2f
Compare
August 6, 2019 13:50
ronag
force-pushed
the
http-buffer-even-while-no-socket
branch
from
6cc9e2f to
292dac1
Compare
August 6, 2019 13:54
4 tasks
lpinca
reviewed
Aug 6, 2019
Comment thread
lib/_http_outgoing.js
Outdated
Comment thread
test/parallel/test-http-outgoing-buffer.js
Outdated
Copy link
Copy Markdown
Member
|
Seems good to me with the getHighWaterMark() issue addressed. |
Sorry, something went wrong.
ronag
force-pushed
the
http-buffer-even-while-no-socket
branch
6 times, most recently
from
6de1993 to
355f5b7
Compare
August 6, 2019 23:24
lpinca
reviewed
Aug 7, 2019
Comment thread
lib/_http_outgoing.js
Outdated
lpinca
reviewed
Aug 7, 2019
Comment thread
test/parallel/test-http-outgoing-buffer.js
Outdated
ronag
force-pushed
the
http-buffer-even-while-no-socket
branch
5 times, most recently
from
53d503b to
0f8400b
Compare
August 8, 2019 11:11
lpinca
approved these changes
Aug 8, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
force-pushed
the
http-buffer-even-while-no-socket
branch
from
0f8400b to
d37b213
Compare
August 9, 2019 16:02
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/streams |
Sorry, something went wrong.
mcollina
approved these changes
Aug 9, 2019
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 9, 2019
PR-URL: nodejs#29019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #29019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be buffering writes even while no socket is assigned.
Checklist