[x] stream: simplify writable buffering - #29026
Closed
ronag wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
force-pushed
the
stream-writable-buffered
branch
from
03b2e7d to
44f11c9
Compare
August 6, 2019 19:47
ronag
force-pushed
the
stream-writable-buffered
branch
6 times, most recently
from
86b6936 to
62b056c
Compare
August 6, 2019 20:10
Copy link
Copy Markdown
Member
Author
|
Future TODO is to merge with #29028 |
Sorry, something went wrong.
ronag
force-pushed
the
stream-writable-buffered
branch
18 times, most recently
from
f5200a9 to
66056be
Compare
August 9, 2019 16:02
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mscdex
reviewed
Aug 25, 2019
Comment thread
lib/_stream_writable.js
Outdated
mscdex
reviewed
Aug 25, 2019
Comment thread
lib/_stream_writable.js
Outdated
mscdex
reviewed
Aug 25, 2019
Comment thread
lib/_stream_writable.js
Outdated
ronag
force-pushed
the
stream-writable-buffered
branch
from
66056be to
c09f94c
Compare
August 25, 2019 20:10
Copy link
Copy Markdown
Member
Author
|
@Trott: those travis errors look strange, what's going on? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Not sure but if it's not happening on Jenkins, I wouldn't worry about it. I just started the tests on Jenkins so let's see what happens... |
Sorry, something went wrong.
mscdex
reviewed
Aug 26, 2019
Comment thread
lib/_stream_writable.js
Outdated
mscdex
reviewed
Aug 26, 2019
Comment thread
lib/_stream_writable.js
Outdated
Co-Authored-By: mscdex <mscdex@users.noreply.github.com>
Copy link
Copy Markdown
Member
Author
|
Closing for now |
Sorry, something went wrong.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the buffering logic in writable_stream and makes it easier to maintain and possiblinly optimize. Also minor speed and memory overhead optimisation.
I have a few ideas on how to further optimize this. But as a first step, simplify while maintaining current performance.
Checklist