FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Assorted typo fixes. by XhmikosR · Pull Request #29075 · nodejs/node · GitHub

/ node Public

Assorted typo fixes. - #29075

Closed
XhmikosR wants to merge 1 commit into
nodejs:masterfrom
XhmikosR:master-xmr-typo-fixes
ConversationCommits (1)ChecksFiles changed
Closed

Assorted typo fixes.#29075
XhmikosR wants to merge 1 commit into
nodejs:masterfrom
XhmikosR:master-xmr-typo-fixes

Conversation

XhmikosR commented Aug 10, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. tools Issues and PRs related to the tools directory. labels Aug 10, 2019

mscdex commented Aug 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

As far as at least commit messages in changelogs go, we usually leave those alone, even if there were spelling mistakes.

XhmikosR commented Aug 10, 2019

Copy link
Copy Markdown
Contributor Author

It's a semi-automated fix, so this was easier for me...

XhmikosR commented Aug 10, 2019

Copy link
Copy Markdown
Contributor Author

For the site nodejs/nodejs.org#2375

XhmikosR mentioned this pull request Aug 10, 2019
Merged

XhmikosR commented Aug 10, 2019

Copy link
Copy Markdown
Contributor Author

Regardless, I can revert the commit message changes here and in the website PR if you guys prefer that.

XhmikosR mentioned this pull request Aug 10, 2019
Merged
mcollina reviewed Aug 10, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The changes to the changelog files are still there

XhmikosR commented Aug 10, 2019 via email

Copy link
Copy Markdown
Contributor Author

XhmikosR commented Aug 10, 2019

Copy link
Copy Markdown
Contributor Author

Done.

Trott commented Aug 12, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3829/

Trott commented Aug 12, 2019

Copy link
Copy Markdown
Member

Landed in f114e5b

Trott closed this Aug 12, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 12, 2019
doc, lib, src, test, tools: fix assorted typos
f114e5b 
PR-URL: nodejs#29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
XhmikosR deleted the master-xmr-typo-fixes branch August 13, 2019 05:20
targos pushed a commit that referenced this pull request Aug 19, 2019
doc, lib, src, test, tools: fix assorted typos
3bfca0b 
PR-URL: #29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 20, 2021
Open
Open
Open
Open
Open
Open
This was referenced Sep 5, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
kissofire mentioned this pull request Jan 1, 2024
Open
aliceUnhinged613 mentioned this pull request Jan 1, 2024
Open
137717unity mentioned this pull request Jan 2, 2024
Open
molllyn1 mentioned this pull request Jan 2, 2024
Open
wedataintelligence mentioned this pull request Jan 2, 2024
Open
ron-a20 mentioned this pull request Jan 2, 2024
Open
molllyn1 mentioned this pull request Mar 15, 2024
Open
ron-a20 mentioned this pull request Mar 15, 2024
Open
kissofire mentioned this pull request Mar 15, 2024
Open
aliceUnhinged613 mentioned this pull request Mar 15, 2024
Open
137717unity mentioned this pull request Mar 16, 2024
Open
wedataintelligence mentioned this pull request Mar 18, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina left review comments
Trott Trott approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL