test: deflake test-tls-passphrase - #29134
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
$ ./tools/test.py -J --repeat=500 test/parallel/test-tls-passphrase.js
=== release test-tls-passphrase ===
Path: parallel/test-tls-passphrase
events.js:186
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event on TLSSocket instance at:
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at processTicksAndRejections (internal/process/task_queues.js:77:11) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
}
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-tls-passphrase.js
=== release test-tls-passphrase ===
Path: parallel/test-tls-passphrase
events.js:186
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event on TLSSocket instance at:
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at processTicksAndRejections (internal/process/task_queues.js:77:11) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
}
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-tls-passphrase.js
...
|
Sorry, something went wrong.
bnoordhuis
approved these changes
Aug 15, 2019
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a suggestion.
Sorry, something went wrong.
Comment thread
test/parallel/test-tls-passphrase.js
Outdated
lpinca
force-pushed
the
deflake/test-tls-passphrase
branch
from
20c24fd to
6db2364
Compare
August 15, 2019 10:19
cjihrig
approved these changes
Aug 15, 2019
sam-github
approved these changes
Aug 15, 2019
sam-github
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@lpinca It looks like you are changing it so client ends connection rather than server, to prevent races. Is it still flaky, or not flaky? I'm not sure if the errors you pinged me about were before or after your fix. The changes LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The error is before fix, it is no longer flaky now unless I raise --repeat to 1000. After that a new errors occurs (EADDRNOTAVAIL) but that is a different issue. See #28337 (comment). Also it looks this fixes #28111. Will add the "Fixes:" metadata. |
Sorry, something went wrong.
Move `socket.end()` to client. Fixes: nodejs#28111 Refs: nodejs#27569
lpinca
force-pushed
the
deflake/test-tls-passphrase
branch
from
6db2364 to
6d6de17
Compare
August 15, 2019 16:11
Trott
approved these changes
Aug 16, 2019
jasnell
approved these changes
Aug 16, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
pushed a commit
that referenced
this pull request
Aug 19, 2019
Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 20, 2019
Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move socket.end() to client.
Fixes: #28111
Refs: #27569
Checklist