FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: optimize creation by ronag · Pull Request #29135 · nodejs/node · GitHub

/ node Public

stream: optimize creation - #29135

Closed
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:stream-creation
ConversationCommits (3)ChecksFiles changed
Closed

stream: optimize creation#29135
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:stream-creation

Conversation

ronag commented Aug 15, 2019

Copy link
Copy Markdown
Member

Optimize stream creation.

 streams/creation.js kind='duplex' n=1000000           ***      9.04 %       ±3.10% ±4.14% ±5.42%
 streams/creation.js kind='readable' n=1000000                  3.64 %       ±3.83% ±5.09% ±6.63%
 streams/creation.js kind='transform' n=1000000        ***      7.87 %       ±3.54% ±4.71% ±6.14%
 streams/creation.js kind='writable' n=1000000                 -1.11 %       ±4.99% ±6.65% ±8.68%

Takes the non-controversial parts of #29127.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Aug 15, 2019

Trott commented Aug 25, 2019

Copy link
Copy Markdown
Member

@nodejs/streams

mcollina approved these changes Aug 26, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mscdex reviewed Sep 12, 2019
View reviewed changes
Comment thread lib/_stream_readable.js Outdated
mscdex reviewed Sep 12, 2019
View reviewed changes
Comment thread lib/_stream_readable.js Outdated

mscdex Sep 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

missing the stream parameter

ronag force-pushed the stream-creation branch 3 times, most recently from e160d2a to 7ce2ad9 Compare September 12, 2019 15:54

mscdex commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

This apparently needs a rebase in order to run benchmarks in CI.

ronag commented Sep 13, 2019

Copy link
Copy Markdown
Member Author

rebased

nodejs-github-bot commented Sep 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25489/

ronag commented Sep 18, 2019

Copy link
Copy Markdown
Member Author

@mscdex: Another try at Benchmark CI?

ZYSzys commented Sep 19, 2019

Copy link
Copy Markdown
Member

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/450/

nodejs-github-bot commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25560/

Trott commented Sep 19, 2019

Copy link
Copy Markdown
Member

Benchmark results from CI:

19:26:09                                                  confidence improvement accuracy (*)   (**)  (***)
19:26:09  streams/creation.js kind='duplex' n=50000000           ***     16.85 %       ±2.12% ±2.82% ±3.67%
19:26:09  streams/creation.js kind='readable' n=50000000                  1.41 %       ±1.82% ±2.43% ±3.16%
19:26:09  streams/creation.js kind='transform' n=50000000        ***      9.88 %       ±1.71% ±2.28% ±2.96%
19:26:09  streams/creation.js kind='writable' n=50000000          **     -3.08 %       ±1.95% ±2.60% ±3.38%
19:26:09

Seems good to me, but posting here in case anyone thinks the one slightly slower benchmark result is critical. (I imagine we're more interested in the two positive results that are both more statistically significant and larger in magnitude.)

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 19, 2019
ZYSzys pushed a commit that referenced this pull request Sep 22, 2019
stream: optimize creation
bd02775 
PR-URL: #29135
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

ZYSzys commented Sep 22, 2019

Copy link
Copy Markdown
Member

Landed in bd02775.

ZYSzys closed this Sep 22, 2019
targos pushed a commit that referenced this pull request Sep 23, 2019
stream: optimize creation
74f1706 
PR-URL: #29135
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
stream: optimize creation
78cbdf3 
PR-URL: #29135
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
This was referenced Sep 26, 2019
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ZYSzys ZYSzys approved these changes
+1 more reviewer
mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL