readline: support closing dumb terminals - #29149
Merged
cjihrig merged 2 commits intoAug 17, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bnoordhuis
approved these changes
Aug 15, 2019
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Would be nice to test ^C as well but LGTM either way.
Sorry, something went wrong.
jasnell
approved these changes
Aug 16, 2019
lpinca
approved these changes
Aug 16, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/25054/ EDIT: CI was green. |
Sorry, something went wrong.
This commit adds support for closing a readline interface on Control+C when the terminal is dumb. PR-URL: nodejs#29149 Fixes: nodejs#29111 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit adds support for closing a readline interface on Control+D when the terminal is dumb. PR-URL: nodejs#29149 Fixes: nodejs#29111 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29111
Checklist