test: add required settings to test-benchmark-buffer - #29163
Merged
Trott merged 0 commit intoAug 16, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Aug 16, 2019
Copy link
Copy Markdown
Member
Author
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3834/ ✔️ Benchmark Test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8565/ ✔️ Benchmark tests do not get run in regular CI, so a full regular CI run should not be necessary. |
Sorry, something went wrong.
ZYSzys
approved these changes
Aug 16, 2019
ZYSzys
approved these changes
Aug 16, 2019
Trott
force-pushed
the
fix-buffer-benchmark-test
branch
from
b997840 to
b9ff6a3
Compare
August 16, 2019 17:16
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
A benchmark was added but the appropriate settings were not added to test-benchmark-buffer. These two additions make sure that the new benchmark file only runs a single benchmark during testing. PR-URL: #29163 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.
node-daily-master on CI will be broken until this lands. 👍 here to fast-track if you're a Collaborator.
Checklist