FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: make pty_helper.py python3-compatible by bnoordhuis · Pull Request #29167 · nodejs/node · GitHub

/ node Public

tools: make pty_helper.py python3-compatible - #29167

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix29166
ConversationCommits (1)ChecksFiles changed
Closed

tools: make pty_helper.py python3-compatible#29167
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix29166

Conversation

bnoordhuis commented Aug 16, 2019

Copy link
Copy Markdown
Member

nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Aug 16, 2019

nodejs-github-bot commented Aug 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25029/

bnoordhuis commented Aug 16, 2019

Copy link
Copy Markdown
Member Author

I suppose the proper prefix is 'test:' because the script lives in test/pseudo-tty. It's invoked by tools/test.py though.

sam-github commented Aug 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Isn't covered by current tests, since they just do py2, but I did a python3 tools/test.py -J pseudo-tty and it works.

sam-github requested a review from cclauss August 16, 2019 20:22
cclauss mentioned this pull request Aug 16, 2019
Closed
63 tasks
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 19, 2019

Trott commented Aug 19, 2019

Copy link
Copy Markdown
Member

Landed in 9c27118

Trott closed this Aug 19, 2019
Trott pushed a commit that referenced this pull request Aug 19, 2019
tools: make pty_helper.py python3-compatible
9c27118 
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 20, 2019
tools: make pty_helper.py python3-compatible
acdc21b 
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Aug 20, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
cclauss Awaiting requested review from cclauss
+1 more reviewer
sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pty_helper.py doesn't work with python3

5 participants

Back | FazBrowse Home | New Git URL