FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

worker: fix crash when SharedArrayBuffer outlives creating thread by addaleax · Pull Request #29190 · nodejs/node · GitHub

/ node Public

worker: fix crash when SharedArrayBuffer outlives creating thread - #29190

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-sharedarraybuffer-childthread-2
ConversationCommits (1)ChecksFiles changed
Closed

worker: fix crash when SharedArrayBuffer outlives creating thread#29190
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-sharedarraybuffer-childthread-2

Conversation

addaleax commented Aug 17, 2019

Copy link
Copy Markdown
Member

Keep a reference to the ArrayBuffer::Allocator alive for at least
as long as a SharedArrayBuffer allocated by it lives.

The tests are taken 1:1 from #28788.

Refs: #28788
Fixes: #28777
Fixes: #28773

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

worker: fix crash when SharedArrayBuffer outlives creating thread
4d2821f 
Keep a reference to the `ArrayBuffer::Allocator` alive for at least
as long as a `SharedArrayBuffer` allocated by it lives.

Refs: nodejs#28788
Fixes: nodejs#28777
Fixes: nodejs#28773
addaleax added the worker Issues and PRs related to Worker support. label Aug 17, 2019
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 17, 2019
addaleax mentioned this pull request Aug 17, 2019
Closed
3 tasks
addaleax removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 17, 2019

nodejs-github-bot commented Aug 17, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25058/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 19, 2019

nodejs-github-bot commented Aug 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25110/

addaleax commented Aug 19, 2019

Copy link
Copy Markdown
Member Author

Landed in 119c4cc

addaleax closed this Aug 19, 2019
addaleax added a commit that referenced this pull request Aug 19, 2019
worker: fix crash when SharedArrayBuffer outlives creating thread
119c4cc 
Keep a reference to the `ArrayBuffer::Allocator` alive for at least
as long as a `SharedArrayBuffer` allocated by it lives.

Refs: #28788
Fixes: #28777
Fixes: #28773

PR-URL: #29190
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax deleted the worker-sharedarraybuffer-childthread-2 branch August 19, 2019 23:00
targos pushed a commit that referenced this pull request Aug 20, 2019
worker: fix crash when SharedArrayBuffer outlives creating thread
d4e397a 
Keep a reference to the `ArrayBuffer::Allocator` alive for at least
as long as a `SharedArrayBuffer` allocated by it lives.

Refs: #28788
Fixes: #28777
Fixes: #28773

PR-URL: #29190
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Aug 20, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
pancaspe87 mentioned this pull request Jul 1, 2025
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

segfault when using SharedArrayBuffer from an unrefed worker thread Access Violation

4 participants

Back | FazBrowse Home | New Git URL