src,lib: make ^C print a JS stack trace by legendecas · Pull Request #29207 · nodejs/node · GitHub

If terminating the process with ctrl-c / SIGINT, prints a JS stack trace leading up to the currently executing code.

The feature would be enabled under option --trace-sigint.

Conditions of no stacktrace on sigint:

has (an) active sigint listener(s);
main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed.

Related: #24937

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Maybe we should only print a stack trace if stdin is a TTY (especially if it's meant to only happen when pressing ctrl-c)?

Left some comments but nice work!

report: is the subsystem for the node-report feature, i.e. node --experimental-report … this touches a related topic, but I think it might be confusing to name it that way

report: is the subsystem for the node-report feature, i.e. node --experimental-report … this touches a related topic, but I think it might be confusing to name it that way

Yes, this work doesn't touch report specifically in codebase. Yet I don't find a more proper subsystem here https://github.com/nodejs/core-validate-commit/blob/master/lib/rules/subsystem.js . Since both src and lib are touched in this work, neither of those one might be appropriate IMO.

@legendecas You can also use src,lib: .... 🙂 Honestly, I don’t have a better idea than that either.

I think this PR is out of WIP, ready to be reviewed thoroughly :)

CI: https://ci.nodejs.org/job/node-test-pull-request/25228/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1980/

@legendecas Looks like there are still issues with the postmortem tests…

@legendecas Looks like there are still issues with the postmortem tests…

I'll try to fix it :P

I don't have any substantive opinions for this.

Since there are no objections anymore and multiple approves, I'd tag this as author-ready.

If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option --trace-sigint. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed.

Rebased to resolve conflicts.

CI: https://ci.nodejs.org/job/node-test-pull-request/28681/

If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option `--trace-sigint`. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed. PR-URL: #29207 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Landed with 7b7e7bd 🎉

/cc @nodejs/tooling this landed 🎉 yay! we might want to talk about it in the next tooling WG meeting

If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option `--trace-sigint`. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed. PR-URL: #29207 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option `--trace-sigint`. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed. PR-URL: nodejs#29207 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option `--trace-sigint`. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed. PR-URL: #29207 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Is it possible to extend this also for sigterm (with a separate flag)?

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 19, 2019

mscdex reviewed Aug 19, 2019

View reviewed changes

Comment thread lib/internal/main/run_main_module.js Outdated

devsnek added the wip Issues and PRs that are still a work in progress. label Aug 19, 2019

addaleax reviewed Aug 20, 2019

View reviewed changes

Comment thread lib/internal/main/run_main_module.js Outdated

Comment thread src/node_watchdog.cc Outdated

Comment thread src/node_watchdog.cc Outdated

Comment thread src/node_watchdog.cc Outdated

Comment thread src/node_watchdog.cc Outdated

bnoordhuis reviewed Aug 20, 2019

View reviewed changes

jasnell reviewed Aug 20, 2019

View reviewed changes

Comment thread src/node_watchdog.cc Outdated

legendecas force-pushed the issue-24937 branch 3 times, most recently from 503aca6 to f175639 Compare August 24, 2019 13:14

legendecas changed the title cli: make ^C print a JS stack trace report: make ^C print a JS stack trace Aug 24, 2019

addaleax approved these changes Aug 24, 2019

View reviewed changes

Comment thread src/node_watchdog.h Outdated

Comment thread src/node_watchdog.h Outdated

Comment thread src/node_watchdog.cc Outdated

Comment thread lib/internal/main/run_main_module.js Outdated

legendecas changed the title report: make ^C print a JS stack trace src,lib: make ^C print a JS stack trace Aug 24, 2019

legendecas force-pushed the issue-24937 branch 2 times, most recently from 3797e8e to 822e56a Compare August 24, 2019 14:13

addaleax approved these changes Aug 24, 2019

View reviewed changes

Comment thread lib/internal/bootstrap/pre_execution.js Outdated

legendecas force-pushed the issue-24937 branch 2 times, most recently from 124c8c3 to b7ccab2 Compare August 24, 2019 16:44

addaleax removed the wip Issues and PRs that are still a work in progress. label Aug 24, 2019

addaleax reviewed Aug 24, 2019

View reviewed changes

Comment thread src/node_watchdog.h Outdated

mscdex reviewed Aug 25, 2019

View reviewed changes

Comment thread lib/internal/bootstrap/pre_execution.js Outdated

mscdex reviewed Aug 25, 2019

View reviewed changes

Comment thread lib/internal/watchdog.js Outdated

mscdex reviewed Aug 25, 2019

View reviewed changes

Comment thread lib/internal/watchdog.js Outdated

Fishrock123 removed their request for review January 14, 2020 19:49

legendecas added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 17, 2020

legendecas removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 25, 2020

legendecas force-pushed the issue-24937 branch from d5694b3 to df403e3 Compare January 25, 2020 15:18

This comment has been minimized.

Sign in to view

legendecas added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 26, 2020

legendecas closed this Jan 28, 2020

legendecas deleted the issue-24937 branch January 28, 2020 05:54

bnoordhuis mentioned this pull request Jan 29, 2020

cli: make ^C print a JS stack trace #24937

Closed

codebytere mentioned this pull request Feb 17, 2020

v13.9.0 proposal #31837

Merged

This was referenced Apr 18, 2020

test: fix flaky test-trace-sigint-on-idle #31645

Closed

src: add missing namespace using statements in node_watchdog.h #32117

Closed

targos removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 25, 2020

targos mentioned this pull request May 2, 2020

v12.17.0 release proposal #33197

Merged

orgads mentioned this pull request Feb 2, 2025

Support printing backtrace also on SIGTERM #56879

Open

src,lib: make ^C print a JS stack trace by legendecas · Pull Request #29207 · nodejs/node · GitHub

Uh oh!

Uh oh!

src,lib: make ^C print a JS stack trace - #29207

src,lib: make ^C print a JS stack trace#29207legendecas wants to merge 1 commit intonodejs:masternodejs/node:masterfrom legendecas:issue-24937legendecas/node:issue-24937Copy head branch name to clipboard

Conversation

legendecas commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

mscdex commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

legendecas commented Aug 24, 2019

Uh oh!

addaleax commented Aug 24, 2019

Uh oh!

Uh oh!

legendecas commented Aug 24, 2019

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 25, 2019

Uh oh!

addaleax commented Aug 25, 2019

Uh oh!

addaleax commented Aug 25, 2019

Uh oh!

legendecas commented Aug 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fishrock123 commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legendecas commented Jan 17, 2020

Uh oh!

legendecas commented Jan 25, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Jan 26, 2020

Uh oh!

legendecas commented Jan 28, 2020

Uh oh!

ruyadorno commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orgads commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

src,lib: make ^C print a JS stack trace#29207
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:issue-24937

legendecas commented Aug 19, 2019 •
edited
Loading

mscdex commented Aug 19, 2019 •
edited
Loading

Fishrock123 commented Jan 14, 2020 •
edited
Loading

ruyadorno commented Jan 28, 2020 •
edited
Loading