FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: allow passing true to emitClose option by gntem · Pull Request #29212 · nodejs/node · GitHub

/ node Public

fs: allow passing true to emitClose option - #29212

Closed
gntem wants to merge 4 commits into
nodejs:masterfrom
gntem:allow-fs-streams-emitclose-true
ConversationCommits (4)ChecksFiles changed
Closed

fs: allow passing true to emitClose option#29212
gntem wants to merge 4 commits into
nodejs:masterfrom
gntem:allow-fs-streams-emitclose-true

Conversation

gntem commented Aug 19, 2019

Copy link
Copy Markdown
Contributor

Allow passing true for emitClose option for fs streams.

Fixes: #29177

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

fs: allow passing true to emitClose option
df1ba97 
Allow passing true for emitClose option for fs
streams.

Fixes: nodejs#29177
nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Aug 19, 2019
cjihrig reviewed Aug 19, 2019
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add tests and some sort of documentation.

addaleax approved these changes Aug 20, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but I’d also really prefer to have a test for this.

Trott commented Aug 22, 2019

Copy link
Copy Markdown
Member

I added tests. PTAL.

Trott commented Aug 22, 2019

Copy link
Copy Markdown
Member

I've also added documentation.

Trott requested review from addaleax, cjihrig and jasnell August 22, 2019 05:14

nodejs-github-bot commented Aug 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25175/

gntem commented Aug 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks a lot @Trott

I tried adding tests for this but the close event was emitted twice even when autoClose: false -- but then again I didn't see a condition for emitClose somewhere in the code.

cjihrig approved these changes Aug 22, 2019
View reviewed changes
Comment thread doc/api/fs.md Outdated
Comment thread doc/api/fs.md Outdated
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 23, 2019

nodejs-github-bot commented Aug 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25198/

Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 23, 2019

Trott commented Aug 23, 2019

Copy link
Copy Markdown
Member

Landed in ceace1f...47ff44e

Trott closed this Aug 23, 2019
Trott pushed a commit that referenced this pull request Aug 23, 2019
fs: allow passing true to emitClose option
eeea3fb 
Allow passing true for emitClose option for fs
streams.

Fixes: #29177

PR-URL: #29212
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit that referenced this pull request Aug 23, 2019
test: add emitClose: true tests for fs streams
cb92126 
PR-URL: #29212
Fixes: #29177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit that referenced this pull request Aug 23, 2019
doc: add emitClose option for fs streams
47ff44e 
PR-URL: #29212
Fixes: #29177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
fs: allow passing true to emitClose option
8f47ff1 
Allow passing true for emitClose option for fs
streams.

Fixes: #29177

PR-URL: #29212
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
test: add emitClose: true tests for fs streams
1f88ca3 
PR-URL: #29212
Fixes: #29177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
doc: add emitClose option for fs streams
65de900 
PR-URL: #29212
Fixes: #29177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR added a commit that referenced this pull request Sep 3, 2019
2019-09-04, Version 12.10.0 (Current)
471f4a9 
Notable changes:

* deps:
  * Update npm to 6.10.3 (isaacs)
    #29023
* fs:
  * Add recursive option to rmdir() (cjihrig)
    #29168
  * Allow passing true to emitClose option (Giorgos Ntemiris)
    #29212
  * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
    #21387
* net:
  * Allow reading data into a static buffer (Brian White)
    #25436

PR-URL: #29429
BridgeAR added a commit that referenced this pull request Sep 4, 2019
2019-09-04, Version 12.10.0 (Current)
3a2e75d 
Notable changes:

* deps:
  * Update npm to 6.10.3 (isaacs)
    #29023
* fs:
  * Add recursive option to rmdir() (cjihrig)
    #29168
  * Allow passing true to emitClose option (Giorgos Ntemiris)
    #29212
  * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
    #21387
* net:
  * Allow reading data into a static buffer (Brian White)
    #25436

PR-URL: #29429
BridgeAR added a commit that referenced this pull request Sep 4, 2019
2019-09-04, Version 12.10.0 (Current)
02c74e7 
Notable changes:

* deps:
  * Update npm to 6.10.3 (isaacs)
    #29023
* fs:
  * Add recursive option to rmdir() (cjihrig)
    #29168
  * Allow passing true to emitClose option (Giorgos Ntemiris)
    #29212
  * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
    #21387
* net:
  * Allow reading data into a static buffer (Brian White)
    #25436

PR-URL: #29429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
trivikr trivikr approved these changes
jasnell Awaiting requested review from jasnell
addaleax Awaiting requested review from addaleax

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs: streams emitClose

7 participants

Back | FazBrowse Home | New Git URL