test: use fs rimraf to refresh tmpdir - #29235
Closed
cjihrig wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit adds a recursive option to fs.rmdir(), fs.rmdirSync(), and fs.promises.rmdir(). The implementation is a port of the npm module rimraf.
Now that the functionality is built into core, use it to refresh the test suite's tmpdir.
Trott
approved these changes
Aug 21, 2019
targos
approved these changes
Aug 21, 2019
Copy link
Copy Markdown
Member
|
https://travis-ci.com/nodejs/node/jobs/226852561#L270 === release test-fs-readdir-ucs2 ===
Path: parallel/test-fs-readdir-ucs2
--- stderr ---
Can't clean tmpdir: /home/travis/build/nodejs/node/test/.tmp.602
Files blocking: [ '=�\u0004�' ]
/home/travis/build/nodejs/node/test/common/tmpdir.js:88
throw e;
^
Error: Unable to rimraf /home/travis/build/nodejs/node/test/.tmp.602
at rimrafSync (/home/travis/build/nodejs/node/test/common/tmpdir.js:42:11)
at process.onexit (/home/travis/build/nodejs/node/test/common/tmpdir.js:73:5)
at process.emit (events.js:214:15)
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-fs-readdir-ucs2.js
|
Sorry, something went wrong.
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore the first two commits, which are just #29168.
Commit: test: use fs rimraf to refresh tmpdir
If rimraf lands in core, we should use it to refresh the tmpdir in our test suite. We should be able to remove even more of this code (like spawning a child process), but I figured this was a good starting point.
Checklist