FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: remove listeners from free sockets by ronag · Pull Request #29259 · nodejs/node · GitHub

/ node Public

http: remove listeners from free sockets - #29259

Closed
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:http-free-listener
ConversationCommits (2)ChecksFiles changed
Closed

http: remove listeners from free sockets#29259
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:http-free-listener

Conversation

ronag commented Aug 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

This is a continuation on #29245 made in a separate PR to make #29245 easier to fast track if desired.

Some more listener cleanup when sockets are detached from the request object and moved into the socket pool.

I'm not sure, but this looks like it might actually be a bug?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Aug 21, 2019
ronag force-pushed the http-free-listener branch 2 times, most recently from 81282c4 to 94a1aa9 Compare August 21, 2019 22:25
ronag changed the title Http free listener http: remove listeners from free sockets Aug 21, 2019
ronag force-pushed the http-free-listener branch from 94a1aa9 to da31643 Compare August 22, 2019 11:20
addaleax approved these changes Aug 25, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but this needs a rebase

ronag force-pushed the http-free-listener branch from da31643 to f9ba882 Compare August 25, 2019 14:40

ronag commented Aug 25, 2019

Copy link
Copy Markdown
Member Author

Rebased

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 25, 2019

nodejs-github-bot commented Aug 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25229/

mcollina reviewed Sep 8, 2019
View reviewed changes
Comment thread test/parallel/test-http-agent-keepalive.js Outdated
Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 9, 2019

ronag commented Sep 23, 2019

Copy link
Copy Markdown
Member Author

rebased

ronag force-pushed the http-free-listener branch 2 times, most recently from 05988bf to f9486be Compare September 23, 2019 07:47
http: free listeners on free sockets
e817a8b 
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.
fixup: check listeners before as well
5c6b99f
ronag force-pushed the http-free-listener branch from e67d546 to 5c6b99f Compare September 23, 2019 20:28
ronag requested a review from mcollina November 11, 2019 17:20
mcollina approved these changes Nov 15, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcollina added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v10.x labels Nov 15, 2019

ronag commented Dec 29, 2019

Copy link
Copy Markdown
Member Author

@Trott: Can this land?

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 30, 2019

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jan 2, 2020 •
edited by BridgeAR
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28112/ ✔️

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
http: free listeners on free sockets
7c70dbb 
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR commented Jan 3, 2020

Copy link
Copy Markdown
Member

Landed in 7c70dbb 🎉

BridgeAR closed this Jan 3, 2020
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
http: free listeners on free sockets
1b720aa 
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
http: free listeners on free sockets
d554aba 
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jan 14, 2020
http: free listeners on free sockets
b840eb7 
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
http: free listeners on free sockets
350cfa7 
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
targos removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL