http: make sure end is always emitted with keepalive connections - #29263
Closed
mcollina wants to merge 2 commits into
Closed
http: make sure end is always emitted with keepalive connections #29263mcollina wants to merge 2 commits into
mcollina wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 779a05d.
This test covers a regression where 'end' was not emitted in the case of keepalive requests without parsing the full body.
2 tasks
benjamingr
approved these changes
Aug 22, 2019
jasnell
approved these changes
Aug 22, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Aug 22, 2019
Copy link
Copy Markdown
Member
|
#9668 should be reopened if/when this is merged. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
pushed a commit
that referenced
this pull request
Aug 24, 2019
This test covers a regression where 'end' was not emitted in the case of keepalive requests without parsing the full body. PR-URL: #29263 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Member
|
This is a bit strange to me. In resOnFinish we emit req.'close'. So essentially the "bug" here is that we emit req.'end' when req.'close' has already been emitted. I think we have a different bug here as well in relation to req.'close'. I'll see if I can make a test. EDIT: yep nxtedition#1 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@ronag The issue is that in resOnFinish the request might not have ended as a readable stream yet. I’m opening a new PR to fix this properly. (Aside, if there’s a regression with one of my PRs, feel free to @addaleax me because I’ve configured my inbox to give explicit mentions of my handledhigher priority over other messages.) |
Sorry, something went wrong.
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Aug 24, 2019
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: nodejs#28646 Refs: nodejs#29263 Fixes: nodejs#9668
This was referenced Aug 24, 2019
targos
pushed a commit
that referenced
this pull request
Aug 26, 2019
This test covers a regression where 'end' was not emitted in the case of keepalive requests without parsing the full body. PR-URL: #29263 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added a commit
that referenced
this pull request
Aug 26, 2019
Notable changes: This release fixes two regressions in the http module: * Fixes an event listener leak in the HTTP client. This resulted in lots of warnings during npm/yarn installs. #29245 * Fixes a regression preventing the `'end'` event from being emitted for keepalive requests in case the full body was not parsed. #29263 PR-URL: #29321
addaleax
added a commit
that referenced
this pull request
Aug 26, 2019
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: #28646 Refs: #29263 Fixes: #9668 PR-URL: #29297 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 26, 2019
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: #28646 Refs: #29263 Fixes: #9668 PR-URL: #29297 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
added a commit
that referenced
this pull request
Aug 26, 2019
Notable changes: This release fixes two regressions in the http module: * Fixes an event listener leak in the HTTP client. This resulted in lots of warnings during npm/yarn installs. #29245 * Fixes a regression preventing the `'end'` event from being emitted for keepalive requests in case the full body was not parsed. #29263 PR-URL: #29321
targos
added a commit
that referenced
this pull request
Aug 26, 2019
Notable changes: This release fixes two regressions in the http module: * Fixes an event listener leak in the HTTP client. This resulted in lots of warnings during npm/yarn installs. #29245 * Fixes a regression preventing the `'end'` event from being emitted for keepalive requests in case the full body was not parsed. #29263 PR-URL: #29321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately 779a05d introduced a regression in 12.8.0, making the autocannon test failing on Node 12. This PR reverts 779a05d and adds a test to ensure that we do not regress again.
Checklist