FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: delete v8_external_snapshot.gypi by ryzokuken · Pull Request #29369 · nodejs/node · GitHub

/ node Public

tools: delete v8_external_snapshot.gypi - #29369

Closed
ryzokuken wants to merge 3 commits into
nodejs:masterfrom
ryzokuken:fix/gh-28964
ConversationCommits (3)ChecksFiles changed
Closed

tools: delete v8_external_snapshot.gypi#29369
ryzokuken wants to merge 3 commits into
nodejs:masterfrom
ryzokuken:fix/gh-28964

Conversation

ryzokuken commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.

Refs: #29363 (comment)
Fixes: #28964

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @gengjiawen @bnoordhuis

tools: delete v8_external_snapshot.gypi
5adb3c1 
Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.

Refs: nodejs#29363 (comment)
Fixes: nodejs#28964
nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 29, 2019
bnoordhuis approved these changes Aug 29, 2019
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with the suggestion to get rid of the v8_use_external_startup_data variable altogether.

Comment thread tools/v8_gypfiles/v8.gyp
bnoordhuis approved these changes Aug 30, 2019
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

nodejs-github-bot commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25302/

ryzokuken commented Aug 30, 2019

Copy link
Copy Markdown
Contributor Author

If CI passes as expected, this should be ready to land by Monday. Thanks all!

targos commented Aug 31, 2019

Copy link
Copy Markdown
Member

@ryzokuken looks like it needs some more work

bnoordhuis reviewed Aug 31, 2019
View reviewed changes
Comment thread tools/v8_gypfiles/v8.gyp Outdated

ryzokuken commented Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

Done! Will land after @bnoordhuis reviews.

gengjiawen commented Sep 4, 2019

Copy link
Copy Markdown
Member

Travis failed with

gyp: name 'v8_use_external_startup_data' is not defined while evaluating condition 'v8_use_external_startup_data' in /home/travis/build/nodejs/node/tools/v8_gypfiles/v8.gyp while loading dependencies of /home/travis/build/nodejs/node/node.gyp while trying to load /home/travis/build/nodejs/node/node.gyp
Error running GYP
The command "./configure" exited with 1.

bnoordhuis commented Sep 5, 2019

Copy link
Copy Markdown
Member

There's one more if-then-else clause in v8.gyp that can be simplified to just the else block.

ryzokuken commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

@bnoordhuis @gengjiawen Ah! Must've missed that. Taking caring of it.

ryzokuken commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

@bnoordhuis PTAL? I suppose this fixes everything.

bnoordhuis reviewed Sep 5, 2019
View reviewed changes
Comment thread tools/v8_gypfiles/v8.gyp

nodejs-github-bot commented Sep 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25370/

ryzokuken added a commit that referenced this pull request Sep 5, 2019
tools: delete v8_external_snapshot.gypi
2882ce9 
Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.

Refs: #29363 (comment)
Fixes: #28964

PR-URL: #29369
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

ryzokuken commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 2882ce9 🎉

ryzokuken closed this Sep 5, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
tools: delete v8_external_snapshot.gypi
9de417a 
Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.

Refs: #29363 (comment)
Fixes: #28964

PR-URL: #29369
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR mentioned this pull request Sep 24, 2019
Merged
This was referenced Sep 25, 2019
Closed
Closed
This was referenced Sep 26, 2019
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
gengjiawen gengjiawen approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V8 build config

6 participants

Back | FazBrowse Home | New Git URL