FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: make execFileSync in line with execFile by lfortin · Pull Request #2940 · nodejs/node · GitHub

/ node Public

doc: make execFileSync in line with execFile - #2940

Closed
lfortin wants to merge 2 commits into
nodejs:masterfrom
lfortin:doc-execfilesync
ConversationCommits (2)ChecksFiles changed
Closed

doc: make execFileSync in line with execFile#2940
lfortin wants to merge 2 commits into
nodejs:masterfrom
lfortin:doc-execfilesync

Conversation

lfortin commented Sep 18, 2015

Copy link
Copy Markdown
Contributor

Make execFileSync API docs in line with execFile API docs.

doc: make execFileSync in line with execFile
66a6f76 
make execFileSync API docs in line with execFile API docs

evanlucas commented Sep 18, 2015

Copy link
Copy Markdown
Contributor

LGTM

brendanashworth added the doc Issues and PRs related to the documentations. label Sep 18, 2015
mscdex added the child_process Issues and PRs related to the child_process subsystem. label Sep 18, 2015

silverwind commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

@lfortin while you're at it, could you move the whole execFileSync section below exexSync so the ordering is the same as for the async methods?

lfortin commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

@silverwind done.

silverwind commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

@lfortin The diff looks a bit unwieldy, this is just a cut-paste job, right?

lfortin commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

@silverwind yes it is. I confirm that the text is well formatted.

silverwind commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

Alright, LGTM.

targos reviewed Sep 22, 2015
View reviewed changes
Comment thread doc/api/child_process.markdown Outdated

targos Sep 22, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure these should have moved. Isn't there a convention to put the link definitions at the end of the file ?

silverwind Sep 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, good catch. These should indeed remain an the end of the file, @lfortin.

lfortin commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

@targos I see, my bad. I will re-issue a new commit with the link definitions at the end of the file.

/cc @silverwind

lfortin commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

@targos @silverwind done.

silverwind reviewed Sep 22, 2015
View reviewed changes
Comment thread doc/api/child_process.markdown Outdated

silverwind Sep 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm sorry but this looks like an unnecessary newline.

doc: rearrange execSync, execFileSync in line with exec, execFile
0134d9c 
rearrange execSync, execFileSync API docs to be in line with exec, execFile API docs

lfortin commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

@silverwind unnecessary new line removed.

silverwind commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

targos commented Sep 22, 2015

Copy link
Copy Markdown
Member

LGTM

silverwind pushed a commit that referenced this pull request Sep 23, 2015
doc: make execFileSync in line with execFile
28da400 
PR-URL: #2940
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind pushed a commit that referenced this pull request Sep 23, 2015
doc: rearrange execSync and execFileSync
2d21092 
Changed the ordering so it is in line with the async methods.

PR-URL: #2940
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

silverwind commented Sep 23, 2015

Copy link
Copy Markdown
Contributor

Thanks, landed in 28da400 and 2d21092.

silverwind closed this Sep 23, 2015
Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
doc: make execFileSync in line with execFile
4fc33ac 
PR-URL: #2940
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
doc: rearrange execSync and execFileSync
5c3f50b 
Changed the ordering so it is in line with the async methods.

PR-URL: #2940
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Sep 30, 2015
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL