FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: remove experimental Python 3 tests by cclauss · Pull Request #29413 · nodejs/node · GitHub

/ node Public

build: remove experimental Python 3 tests - #29413

Closed
cclauss wants to merge 1 commit into
masterfrom
Remove-Python-3-tests
Closed

build: remove experimental Python 3 tests#29413
cclauss wants to merge 1 commit into
masterfrom
Remove-Python-3-tests

Conversation

cclauss commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 3, 2019
danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 3, 2019

danbev commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

Could we fast track this? Please give a 👍 if you agree or please remove the fast-track label if you disagree.

danbev pushed a commit that referenced this pull request Sep 3, 2019
These tests do not help us to get closer to Python 3 compatibility and
they take up valuable time yet they always fail.

PR-URL: #29413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

danbev commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

Landed in eb2deee.

danbev closed this Sep 3, 2019
cclauss deleted the Remove-Python-3-tests branch September 3, 2019 12:28
cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Sep 3, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
These tests do not help us to get closer to Python 3 compatibility and
they take up valuable time yet they always fail.

PR-URL: #29413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BridgeAR mentioned this pull request Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL