FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: add encodeInto to TextEncoder by addaleax · Pull Request #29524 · nodejs/node · GitHub

/ node Public

util: add encodeInto to TextEncoder - #29524

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:encode-into
ConversationCommits (3)ChecksFiles changed
Closed

util: add encodeInto to TextEncoder#29524
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:encode-into

Conversation

addaleax commented Sep 10, 2019

Copy link
Copy Markdown
Member

Continuation of @AtticusYang’s #28862

Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

util: add encodeInto to TextEncoder
01698e6 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: nodejs#28851
Fixes: nodejs#26904
Refs: nodejs#28862
Co-authored-by: AtticusYang <yyongtai@163.com>
addaleax added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Sep 10, 2019
nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Sep 10, 2019
devnexen approved these changes Sep 11, 2019
View reviewed changes
Comment thread src/node_buffer.cc Outdated
joyeecheung approved these changes Sep 11, 2019
View reviewed changes
Comment thread test/wpt/status/encoding.json Outdated

AtticusYang commented Sep 11, 2019

Copy link
Copy Markdown

coooool

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 11, 2019
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 11, 2019

nodejs-github-bot commented Sep 11, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25430/

Trott reviewed Sep 13, 2019
View reviewed changes
Comment thread doc/api/util.md Outdated

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25470/

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25476/

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25478/

addaleax added a commit that referenced this pull request Sep 13, 2019
util: add encodeInto to TextEncoder
7c9ee6d 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: #29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax commented Sep 13, 2019

Copy link
Copy Markdown
Member Author

Landed in 7c9ee6d 🎉

Thanks @AtticusYang for all the work you’ve put into this!

addaleax closed this Sep 13, 2019
addaleax deleted the encode-into branch September 13, 2019 18:36
targos pushed a commit that referenced this pull request Sep 20, 2019
util: add encodeInto to TextEncoder
11d1ef9 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: #29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 24, 2019
2019-09-24, Version 12.11.0 (Current)
21e8f36 
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512
BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
util: add encodeInto to TextEncoder
772a5e0 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: #29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 25, 2019
2019-09-24, Version 12.11.0 (Current)
b50c01c 
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
BridgeAR added a commit that referenced this pull request Sep 25, 2019
2019-09-24, Version 12.11.0 (Current)
d36b6f8 
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
skyclouds2001 mentioned this pull request Nov 20, 2024
Closed
aduh95 mentioned this pull request Nov 25, 2024
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 27, 2024
doc: add history entry for textEncoder.encodeInto()
090aa8b 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Dec 2, 2024
doc: add history entry for textEncoder.encodeInto()
96926ce 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
doc: add history entry for textEncoder.encodeInto()
52d5222 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
doc: add history entry for textEncoder.encodeInto()
3558a19 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
doc: add history entry for textEncoder.encodeInto()
6d02bd6 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
marco-ippolito pushed a commit that referenced this pull request Jan 22, 2025
doc: add history entry for textEncoder.encodeInto()
1498396 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
marco-ippolito pushed a commit that referenced this pull request Jan 24, 2025
doc: add history entry for textEncoder.encodeInto()
e016f68 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
joyeecheung joyeecheung approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MessageChannel is not defined in encodeInto.any.js Add TextEncoder.prototype.encodeInto

8 participants

Back | FazBrowse Home | New Git URL