FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: fix bug in fs module autocompletion by ZYSzys · Pull Request #29555 · nodejs/node · GitHub

/ node Public

repl: fix bug in fs module autocompletion - #29555

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:fix-repl
ConversationCommits (1)ChecksFiles changed
Closed

repl: fix bug in fs module autocompletion#29555
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:fix-repl

Conversation

ZYSzys commented Sep 14, 2019

Copy link
Copy Markdown
Member

Fixes: #29424

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Sep 14, 2019

nodejs-github-bot commented Sep 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25485/

ZYSzys commented Sep 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I wonder why we changed baseName to filePath in #26648 (comment) ?

/cc @BridgeAR @antsmartian

nodejs-github-bot commented Sep 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25495/

Trott commented Sep 16, 2019

Copy link
Copy Markdown
Member

@nodejs/fs @nodejs/repl @BridgeAR @antsmartian This could use some reviews.

antsmartian approved these changes Sep 17, 2019
View reviewed changes

antsmartian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. (I don't remember, why we changed this, but this is what was actually causing the issue.)

BridgeAR approved these changes Sep 17, 2019
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZYSzys added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 18, 2019
ZYSzys pushed a commit that referenced this pull request Sep 18, 2019
repl: fix bug in fs module autocompletion
2f497a6 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Trott commented Sep 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 6ed026f Landed in 2f497a6

Trott closed this Sep 18, 2019

ZYSzys commented Sep 18, 2019

Copy link
Copy Markdown
Member Author

Landed in 2f497a6 too ? (It seems that we land this at the same time :)

Trott commented Sep 18, 2019

Copy link
Copy Markdown
Member

Landed in 2f497a6 too ? (It seems that we land this at the same time :)

Ha ha! Yes, I posted my comment too soon. Yours landed first and is the one on master now.

ZYSzys deleted the fix-repl branch September 18, 2019 02:05
targos pushed a commit that referenced this pull request Sep 20, 2019
repl: fix bug in fs module autocompletion
93ce43e 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
repl: fix bug in fs module autocompletion
7eae707 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR approved these changes
+1 more reviewer
antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

repl: bug in fs module autocompletion

5 participants

Back | FazBrowse Home | New Git URL