crypto: use BoringSSL-compatible flag getter - #29604
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Sep 18, 2019
bnoordhuis
approved these changes
Sep 18, 2019
cjihrig
approved these changes
Sep 18, 2019
Trott
approved these changes
Sep 19, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
devnexen
approved these changes
Sep 19, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tniessen
approved these changes
Sep 21, 2019
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you, Shelley!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landed in ef2e9e3 |
Sorry, something went wrong.
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
PR-URL: #29604 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
PR-URL: #29604 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29604 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes HashInit to return the md flags via EVP_MD_flags() instead of EVP_MD_meth_get_flags().
In OpenSSL 1.1.1c, which Node.js bundles at present, these functions are implemented in precisely the same way (see linked implementations above), with the primary difference being that EVP_MD_flags() is exposed by BoringSSL whereas EVP_MD_meth_get_flags() is not.
This allows Electron to reduce its patch surface while changing no behavior in Node.js.
cc @tniessen
Checklist