FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

console: skip/strip %c formatting by devsnek · Pull Request #29606 · nodejs/node · GitHub

/ node Public

console: skip/strip %c formatting - #29606

Closed
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:console-css-skip
Closed

console: skip/strip %c formatting#29606
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:console-css-skip

Conversation

devsnek commented Sep 18, 2019
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #29605
Refs: https://console.spec.whatwg.org

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

devsnek added util Issues and PRs related to the built-in util module. console Issues and PRs related to the console subsystem. labels Sep 18, 2019
Comment thread doc/api/util.md Outdated
Comment thread doc/api/util.md Outdated
Fixes: nodejs#29605
Refs: https://console.spec.whatwg.org
Co-Authored-By: Anna Henningsen <github@addaleax.net>

Copy link
Copy Markdown
Collaborator

ZYSzys added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 19, 2019

shobhitchittora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

addaleax pushed a commit that referenced this pull request Sep 21, 2019
Fixes: #29605
Refs: https://console.spec.whatwg.org
PR-URL: #29606
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Copy link
Copy Markdown
Member

Landed in 8235ffd

addaleax closed this Sep 21, 2019
devsnek deleted the console-css-skip branch September 21, 2019 23:01
devsnek removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 21, 2019
targos pushed a commit that referenced this pull request Sep 23, 2019
Fixes: #29605
Refs: https://console.spec.whatwg.org
PR-URL: #29606
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Fixes: #29605
Refs: https://console.spec.whatwg.org
PR-URL: #29606
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

console Issues and PRs related to the console subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

console: add support for %c style formatter in console.log()

10 participants


Back | FazBrowse Home | New Git URL