FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: check for NODE_REPL_EXTERNAL_MODULE by devsnek · Pull Request #29778 · nodejs/node · GitHub

/ node Public

repl: check for NODE_REPL_EXTERNAL_MODULE - #29778

Merged
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:feature/external-repl
Oct 11, 2019
ConversationCommits (1)ChecksFiles changed
Merged

repl: check for NODE_REPL_EXTERNAL_MODULE#29778
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:feature/external-repl

Conversation

devsnek commented Sep 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

devsnek added repl Issues and PRs related to the REPL subsystem. cli Issues and PRs related to the Node.js command line interface. labels Sep 30, 2019

devsnek commented Sep 30, 2019

Copy link
Copy Markdown
Member Author

cc @nodejs/repl @joyeecheung @jdalton

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 30, 2019
targos reviewed Sep 30, 2019
View reviewed changes
Comment thread doc/api/cli.md Outdated

targos commented Sep 30, 2019

Copy link
Copy Markdown
Member

Are there existing npm modules which would work with this option?

devsnek commented Sep 30, 2019

Copy link
Copy Markdown
Member Author

@targos i don't know. I'm using this change locally to test https://github.com/nodejs/repl more aggressively.

cjihrig reviewed Sep 30, 2019
View reviewed changes
Comment thread doc/api/cli.md Outdated
ZYSzys reviewed Oct 1, 2019
View reviewed changes
Comment thread lib/internal/main/repl.js Outdated
devsnek commented Oct 2, 2019
View reviewed changes
Comment thread test/parallel/test-repl-external-module.js Outdated
Trott reviewed Oct 2, 2019
View reviewed changes
Comment thread test/parallel/test-repl-external-module.js Outdated
devsnek force-pushed the feature/external-repl branch from 53f3979 to 3b081bb Compare October 6, 2019 19:39

nodejs-github-bot commented Oct 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25881/

cjihrig approved these changes Oct 7, 2019
View reviewed changes
Comment thread doc/api/cli.md Outdated
Comment thread lib/internal/main/repl.js Outdated

nodejs-github-bot commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25907/

devsnek force-pushed the feature/external-repl branch from 520f6c7 to b874e1c Compare October 8, 2019 20:26

nodejs-github-bot commented Oct 11, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25964/

repl: check for NODE_REPL_EXTERNAL_MODULE
c0305af 
PR-URL: nodejs#29778
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
devsnek force-pushed the feature/external-repl branch from b874e1c to c0305af Compare October 11, 2019 19:34
devsnek merged commit c0305af into nodejs:master Oct 11, 2019

devsnek commented Oct 11, 2019

Copy link
Copy Markdown
Member Author

landed in c0305af

devsnek deleted the feature/external-repl branch October 11, 2019 19:35
BethGriggs mentioned this pull request Oct 21, 2019
Merged
targos pushed a commit that referenced this pull request Jan 8, 2020
repl: check for NODE_REPL_EXTERNAL_MODULE
e6397aa 
PR-URL: #29778
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
molllyn1 mentioned this pull request Nov 5, 2022
Open
snyk-bot mentioned this pull request Nov 5, 2022
Open
baby636 mentioned this pull request Nov 5, 2022
Open
ron-a20 mentioned this pull request Nov 5, 2022
Open
wedataintelligence mentioned this pull request Nov 5, 2022
Open
kissofire mentioned this pull request Nov 5, 2022
Open
aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
wedataintelligence mentioned this pull request Dec 25, 2022
Open
kissofire mentioned this pull request Dec 25, 2022
Open
molllyn1 mentioned this pull request Dec 26, 2022
Open
137717unity mentioned this pull request Dec 26, 2022
Open
baby636 mentioned this pull request Dec 26, 2022
Open
snyk-bot mentioned this pull request Dec 26, 2022
Open
ron-a20 mentioned this pull request Oct 1, 2023
Open
aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
kissofire mentioned this pull request Oct 1, 2023
Open
wedataintelligence mentioned this pull request Oct 2, 2023
Open
molllyn1 mentioned this pull request Oct 2, 2023
Open
137717unity mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Jan 2, 2024
Open
ron-a20 mentioned this pull request Jan 9, 2024
Open
kissofire mentioned this pull request Jan 9, 2024
Open
aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
molllyn1 mentioned this pull request Jan 9, 2024
Open
137717unity mentioned this pull request Jan 9, 2024
Open
wedataintelligence mentioned this pull request Jan 9, 2024
Open
baby636 mentioned this pull request Jan 9, 2024
Open
baby636 mentioned this pull request Mar 19, 2024
Open
baby636 mentioned this pull request Mar 27, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
ZYSzys ZYSzys approved these changes
targos Awaiting requested review from targos
Trott Awaiting requested review from Trott
BridgeAR Awaiting requested review from BridgeAR

Assignees

No one assigned

Labels

cli Issues and PRs related to the Node.js command line interface. repl Issues and PRs related to the REPL subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL