FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm: add Synthetic modules by devsnek · Pull Request #29864 · nodejs/node · GitHub

/ node Public

vm: add Synthetic modules - #29864

Closed
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:more-vm-shenanigans
ConversationCommits (1)ChecksFiles changed
Closed

vm: add Synthetic modules#29864
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:more-vm-shenanigans

Conversation

devsnek commented Oct 6, 2019

Copy link
Copy Markdown
Member
  • Refactor vm.SourceTextModule (again)
  • Add vm.Module abstract superclass
  • Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

devsnek added vm Issues and PRs related to the vm subsystem. experimental Issues and PRs related to experimental features. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 6, 2019
nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 6, 2019

devsnek commented Oct 6, 2019

Copy link
Copy Markdown
Member Author

cc @vsemozhetbyt

devsnek force-pushed the more-vm-shenanigans branch from d3a8f85 to 99f84f0 Compare October 6, 2019 21:12
devsnek removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 6, 2019
devsnek force-pushed the more-vm-shenanigans branch 3 times, most recently from c396c6e to 20ee326 Compare October 7, 2019 19:07
vsemozhetbyt reviewed Oct 7, 2019
View reviewed changes
Comment thread tools/doc/type-parser.js Outdated
Comment thread doc/api/vm.md Outdated
Comment thread doc/api/vm.md Outdated
guybedford approved these changes Oct 7, 2019
View reviewed changes

guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice work.

Comment thread test/parallel/test-vm-module-synthetic.js Outdated
Comment thread src/module_wrap.cc Outdated
Comment thread src/module_wrap.cc Outdated
addaleax reviewed Oct 7, 2019
View reviewed changes
Comment thread src/node_util.cc Outdated
targos reviewed Oct 8, 2019
View reviewed changes
Comment thread doc/api/vm.md Outdated
targos reviewed Oct 8, 2019
View reviewed changes
Comment thread doc/api/vm.md Outdated

targos Oct 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What happens if name was not listed in exportNames?

devsnek Oct 8, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the spec says a ReferenceError is thrown but V8 currently aborts. I posted about it on the bug tracker yesterday so hopefully it will be fixed soon.

devsnek force-pushed the more-vm-shenanigans branch 3 times, most recently from 3b8872d to 380891b Compare October 12, 2019 07:11
vm: add Synthetic modules
baf46f6 
- Refactor vm.SourceTextModule (again)
- Add vm.Module abstract superclass
- Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records
devsnek force-pushed the more-vm-shenanigans branch from 380891b to baf46f6 Compare October 12, 2019 18:28

nodejs-github-bot commented Oct 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25988/

Trott commented Oct 13, 2019

Copy link
Copy Markdown
Member

@nodejs/vm

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 13, 2019
Trott pushed a commit that referenced this pull request Oct 14, 2019
vm: add Synthetic modules
f9caee9 
- Refactor vm.SourceTextModule (again)
- Add vm.Module abstract superclass
- Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records

PR-URL: #29864
Reviewed-By: Guy Bedford <guybedford@gmail.com>

Trott commented Oct 14, 2019

Copy link
Copy Markdown
Member

Landed in f9caee9

Trott closed this Oct 14, 2019
devsnek deleted the more-vm-shenanigans branch October 14, 2019 21:51
molllyn1 mentioned this pull request Nov 5, 2022
Open
snyk-bot mentioned this pull request Nov 5, 2022
Open
baby636 mentioned this pull request Nov 5, 2022
Open
ron-a20 mentioned this pull request Nov 5, 2022
Open
wedataintelligence mentioned this pull request Nov 5, 2022
Open
kissofire mentioned this pull request Nov 5, 2022
Open
aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
wedataintelligence mentioned this pull request Dec 25, 2022
Open
kissofire mentioned this pull request Dec 25, 2022
Open
molllyn1 mentioned this pull request Dec 26, 2022
Open
137717unity mentioned this pull request Dec 26, 2022
Open
baby636 mentioned this pull request Dec 26, 2022
Open
snyk-bot mentioned this pull request Dec 26, 2022
Open
ron-a20 mentioned this pull request Oct 1, 2023
Open
aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
kissofire mentioned this pull request Oct 1, 2023
Open
wedataintelligence mentioned this pull request Oct 2, 2023
Open
molllyn1 mentioned this pull request Oct 2, 2023
Open
137717unity mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Jan 2, 2024
Open
ron-a20 mentioned this pull request Jan 9, 2024
Open
kissofire mentioned this pull request Jan 9, 2024
Open
aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
molllyn1 mentioned this pull request Jan 9, 2024
Open
137717unity mentioned this pull request Jan 9, 2024
Open
wedataintelligence mentioned this pull request Jan 9, 2024
Open
baby636 mentioned this pull request Jan 9, 2024
Open
baby636 mentioned this pull request Mar 19, 2024
Open
baby636 mentioned this pull request Mar 27, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

guybedford guybedford approved these changes
addaleax addaleax left review comments
joyeecheung Awaiting requested review from joyeecheung
+3 more reviewers
targos targos left review comments
Jamesernator Jamesernator left review comments
vsemozhetbyt vsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. experimental Issues and PRs related to experimental features. semver-minor PRs that contain new features and should be released in the next minor version. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL