FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add missing deprecation code by cjihrig · Pull Request #29969 · nodejs/node · GitHub

/ node Public

doc: add missing deprecation code - #29969

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dep
ConversationCommits (1)ChecksFiles changed
Closed

doc: add missing deprecation code#29969
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dep

Conversation

cjihrig commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

Refs: #29061

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Oct 14, 2019

Trott commented Oct 14, 2019

Copy link
Copy Markdown
Member

You can always count on me to mess this up.

Trott commented Oct 14, 2019

Copy link
Copy Markdown
Member

Collaborators, +1 here to fast-track. I'd like to make sure a release candidate doesn't go out without this, for example.

Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 14, 2019

nodejs-github-bot commented Oct 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26022/

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26025/

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26027/

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26034/

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26037/

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member

Getting a clean CI on this will probably require landing #29979 first.

Trott mentioned this pull request Oct 15, 2019
Merged
2 tasks

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26045/

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26051/

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26055/

Trott commented Oct 16, 2019

Copy link
Copy Markdown
Member

Landed in ff5a1cf

Trott closed this Oct 16, 2019
Trott pushed a commit that referenced this pull request Oct 16, 2019
doc: add missing deprecation code
ff5a1cf 
Refs: #29061

PR-URL: #29969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
cjihrig deleted the dep branch October 16, 2019 13:50
BethGriggs pushed a commit that referenced this pull request Oct 22, 2019
doc: add missing deprecation code
efa6bea 
Refs: #29061

PR-URL: #29969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs mentioned this pull request Oct 22, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes
+3 more reviewers
Fishrock123 Fishrock123 approved these changes
antsmartian antsmartian approved these changes
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL