deps: remove and gitignore .bin directory - #3004
Merged
bnoordhuis merged 1 commit intoSep 24, 2015
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM, unless it is absolutely necessary to have for npm. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
We don't need this atm. I can see us rolling this back in the future if we ever reorganize how our scripts work? But benign enough for now. LGTM |
Sorry, something went wrong.
The .bin/ directory in deps/npm/node_modules seens to have been an accidental check-in in commit e79ccee ("npm: upgrade to v2.1.18"). It causes trouble for distro packagers so delete it and blacklist it. Fixes: nodejs#2839 PR-URL: nodejs#3004 Reviewed-By: Kat Marchán <kzm@sykosomatic.org> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
bnoordhuis
force-pushed
the
fix-2839
branch
from
443b111 to
6ac79bc
Compare
September 24, 2015 18:07
bnoordhuis
added a commit
that referenced
this pull request
Sep 25, 2015
The .bin/ directory in deps/npm/node_modules seens to have been an accidental check-in in commit e79ccee ("npm: upgrade to v2.1.18"). It causes trouble for distro packagers so delete it and blacklist it. Fixes: #2839 PR-URL: #3004 Reviewed-By: Kat Marchán <kzm@sykosomatic.org> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Sep 30, 2015
Copy link
Copy Markdown
Contributor
|
landed in lts-v4.x-staging as 039f73f |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .bin/ directory in deps/npm/node_modules seens to have been an
accidental check-in in commit e79ccee ("npm: upgrade to v2.1.18").
It causes trouble for distro packagers so delete it and blacklist it.
Fixes: #2839
R=@rvagg? /cc @othiym23
CI: https://ci.nodejs.org/job/node-test-pull-request/359/