repl: fix current path for dynamic module imports - #30060
Closed
eemeli wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Adds a trailing slash to the current directory's path that's used as the second argument of `asyncESM.ESMLoader.import(specifier, pwd)`. Without the slash, relative paths will incorrectly resolve from one directory level higher up.
jasnell
approved these changes
Oct 26, 2019
Copy link
Copy Markdown
Member
|
@eemeli thank you very much for your contribution! Seems like this was already fixed by #30609 and the modules team missed to have a look at this. I am very sorry about this, since this looks like great work! I hope to see further pull requests, since this one can not land anymore. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a terminal / missing from the current path when calling import() from the REPL. This means that in a dir /foo/bar calling import('./dog.js') will look for /foo/dog.js, even though it should be looking for /foo/bar/dog.js.
Here's a minimal reproduction:
docker run -it --rm node:12.13.0 bash mkdir -p /tmp/foo/bar cd /tmp/foo/bar echo "console.log('Yes, this is dog')" > dog.js echo "import('./dog.js')" > call.js node --experimental-modules call.js (node:8) ExperimentalWarning: The ESM module loader is experimental. Yes, this is dog node --experimental-modules Welcome to Node.js v12.13.0. Type ".help" for more information. > (node:15) ExperimentalWarning: The ESM module loader is experimental. > import('./dog.js').then(console.log, console.error) Promise { <pending> } > Error: Cannot find module /tmp/foo/dog.js imported from /tmp/foo/bar at Loader.resolve [as _resolve] (internal/modules/esm/default_resolve.js:82:13) at Loader.resolve (internal/modules/esm/loader.js:73:33) at Loader.getModuleJob (internal/modules/esm/loader.js:147:40) at Loader.import (internal/modules/esm/loader.js:131:28) at vm.createScript.importModuleDynamically (repl.js:343:59) at processTicksAndRejections (internal/process/task_queues.js:93:5) at async importModuleDynamicallyWrapper (internal/vm/source_text_module.js:292:17) { code: 'ERR_MODULE_NOT_FOUND' } > import(path.resolve('./dog.js')).then(console.log, console.error) Promise { <pending> } > Yes, this is dog [Module] { default: {} }Checklist