FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove "it is important to" phrasing by Trott · Pull Request #30108 · nodejs/node · GitHub

/ node Public

doc: remove "it is important to" phrasing - #30108

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:it-is-important
Oct 26, 2019
ConversationCommits (1)ChecksFiles changed
Merged

doc: remove "it is important to" phrasing#30108
Trott merged 1 commit into
nodejs:masterfrom
Trott:it-is-important

Conversation

Trott commented Oct 24, 2019

Copy link
Copy Markdown
Member

Instead of telling someone "It is important to do X", just tell them to
"Do X."

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Oct 24, 2019
mhdawson approved these changes Oct 24, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

cjihrig approved these changes Oct 25, 2019
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I think it is important to land this PR.

gireeshpunathil added the doc Issues and PRs related to the documentations. label Oct 25, 2019

gireeshpunathil commented Oct 25, 2019

Copy link
Copy Markdown
Member

Is tls label applied by the bot a bug? or by design?
( fwiw, tls is the first non-doc file in the list of files in this PR, as it appears in the web interface, but there is a C++ file and a test case too.)

richardlau commented Oct 25, 2019

Copy link
Copy Markdown
Member

Is tls label applied by the bot a bug? or by design?
( fwiw, tls is the first non-doc file in the list of files in this PR, as it appears in the web interface, but there is a C++ file and a test case too.)

The bot just attempts to match each modified file to the list of rules it has and applies the appropriate label if a rule matches. In this case https://github.com/nodejs/github-bot/blob/ab459fd1382ec2d9ae16ef34b9d00e321b29699e/lib/node-labels.js#L95 matches lib/_tls_common.js.

nodejs-github-bot commented Oct 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26208/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 26, 2019

nodejs-github-bot commented Oct 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26213/

nodejs-github-bot commented Oct 26, 2019 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26216/ ✔️

doc: remove "it is important to" phrasing
72346bd 
Instead of telling someone "It is important to do X", just tell them to
"Do X."

PR-URL: nodejs#30108
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott merged commit 72346bd into nodejs:master Oct 26, 2019

Trott commented Oct 26, 2019

Copy link
Copy Markdown
Member Author

Landed in 72346bd

targos pushed a commit that referenced this pull request Oct 28, 2019
doc: remove "it is important to" phrasing
621eaf9 
Instead of telling someone "It is important to do X", just tell them to
"Do X."

PR-URL: #30108
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
doc: remove "it is important to" phrasing
062fc27 
Instead of telling someone "It is important to do X", just tell them to
"Do X."

PR-URL: #30108
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
doc: remove "it is important to" phrasing
e5cb896 
Instead of telling someone "It is important to do X", just tell them to
"Do X."

PR-URL: #30108
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
doc: remove "it is important to" phrasing
70b7bc3 
Instead of telling someone "It is important to do X", just tell them to
"Do X."

PR-URL: #30108
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
doc: remove "it is important to" phrasing
2ac76e3 
Instead of telling someone "It is important to do X", just tell them to
"Do X."

PR-URL: #30108
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig added a commit to cjihrig/node that referenced this pull request Jun 2, 2020
doc: remove "it is important"
d534052 
In the spirit of nodejs#30108, remove the use of "it is important" in
the new EventTarget docs.

PR-URL: nodejs#33678
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
doc: remove "it is important"
1e4edd8 
In the spirit of #30108, remove the use of "it is important" in
the new EventTarget docs.

PR-URL: #33678
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
doc: remove "it is important"
f54fb3c 
In the spirit of #30108, remove the use of "it is important" in
the new EventTarget docs.

PR-URL: #33678
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
trivikr trivikr approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL