FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix numbering in require algorithm by hybrist · Pull Request #30117 · nodejs/node · GitHub

/ node Public

doc: fix numbering in require algorithm - #30117

Closed
hybrist wants to merge 1 commit into
nodejs:masterfrom
hybrist:self-ref-doc-fix
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix numbering in require algorithm#30117
hybrist wants to merge 1 commit into
nodejs:masterfrom
hybrist:self-ref-doc-fix

Conversation

hybrist commented Oct 25, 2019

Copy link
Copy Markdown
Contributor
Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Oct 25, 2019
hybrist mentioned this pull request Oct 25, 2019
Closed
12 tasks

targos commented Oct 25, 2019

Copy link
Copy Markdown
Member

I don't know if our doc generator supports it, but normally in markdown you can just put 1. everywhere and the numbering is done automatically

hybrist commented Oct 25, 2019

Copy link
Copy Markdown
Contributor Author

I don't know if our doc generator supports it, but normally in markdown you can just put 1. everywhere and the numbering is done automatically

Good point and good question. Tried it out locally. The bad news is that it doesn't work, the output preserves the 1s (and as). The good news is that I found another place where the ordering was wrong. In another part of the algorithm a sub-list had two as.

hybrist added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 25, 2019

nodejs-github-bot commented Oct 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26199/

nodejs-github-bot commented Oct 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26201/

nodejs-github-bot commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26230/

alexzherdev mentioned this pull request Oct 29, 2019
Closed
4 tasks
hybrist added a commit that referenced this pull request Oct 29, 2019
doc: fix numbering in require algorithm
050a3b1 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

hybrist commented Oct 29, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 050a3b1

hybrist closed this Oct 29, 2019
targos pushed a commit that referenced this pull request Nov 5, 2019
doc: fix numbering in require algorithm
403a648 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
doc: fix numbering in require algorithm
434d24b 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos commented Nov 10, 2019

Copy link
Copy Markdown
Member

depends on #29327 to land on v12.x

targos pushed a commit that referenced this pull request Jan 8, 2020
doc: fix numbering in require algorithm
a1b124c 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jan 8, 2020
doc: fix numbering in require algorithm
31d3864 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc: fix numbering in require algorithm
2d5aec0 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
trivikr trivikr approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL