FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: git rm -r tools/v8_gypfiles/broken by cclauss · Pull Request #30149 · nodejs/node · GitHub

/ node Public

tools: git rm -r tools/v8_gypfiles/broken - #30149

Closed
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:git-rm-tools-v8_gypfiles-broken
ConversationCommits (1)ChecksFiles changed
Closed

tools: git rm -r tools/v8_gypfiles/broken#30149
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:git-rm-tools-v8_gypfiles-broken

Conversation

cclauss commented Oct 27, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Discovered by #30143 the tools/v8_gypfiles/broken has at least three
files that contain Python 3 syntax errors or call removed Python builtins.

https://travis-ci.com/nodejs/node/jobs/249935565#L267-L275

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 27, 2019
cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 27, 2019
bnoordhuis approved these changes Oct 28, 2019
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 28, 2019

nodejs-github-bot commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26233/

cclauss added a commit that referenced this pull request Oct 31, 2019
tools: git rm -r tools/v8_gypfiles/broken
1f080fc 
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

cclauss commented Oct 31, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 1f080fc

cclauss closed this Oct 31, 2019
cclauss deleted the git-rm-tools-v8_gypfiles-broken branch October 31, 2019 16:15
targos pushed a commit that referenced this pull request Nov 5, 2019
tools: git rm -r tools/v8_gypfiles/broken
14981f5 
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
tools: git rm -r tools/v8_gypfiles/broken
a36c965 
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
tools: git rm -r tools/v8_gypfiles/broken
27f7d3e 
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
tools: git rm -r tools/v8_gypfiles/broken
a90ba3a 
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
tools: git rm -r tools/v8_gypfiles/broken
df0fbf2 
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
sam-github Awaiting requested review from sam-github
Trott Awaiting requested review from Trott
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL