FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

configure: iojs -> nodejs by pmq20 · Pull Request #3015 · nodejs/node · GitHub

/ node Public

configure: iojs -> nodejs - #3015

Closed
pmq20 wants to merge 1 commit into
nodejs:masterfrom
pmq20:minqi-pan-sep-23
Closed

configure: iojs -> nodejs#3015
pmq20 wants to merge 1 commit into
nodejs:masterfrom
pmq20:minqi-pan-sep-23

Conversation

pmq20 commented Sep 23, 2015

Copy link
Copy Markdown
Contributor

Inconsistency between configure and node.cc.

rvagg commented Sep 23, 2015

Copy link
Copy Markdown
Member

good catch, lgtm

Copy link
Copy Markdown
Contributor

LGTM

brendanashworth added the build Issues and PRs related to build files or the CI. label Sep 23, 2015

pmq20 commented Sep 23, 2015

Copy link
Copy Markdown
Contributor Author

changed commit message to "build" as subsystem.

Copy link
Copy Markdown
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Sep 23, 2015
PR-URL: #3015
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

Copy link
Copy Markdown
Contributor

Thanks, landed in 76c80d4.

silverwind closed this Sep 23, 2015
Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
PR-URL: #3015
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL