FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use forward declaration instead of include by fhinkel · Pull Request #30159 · nodejs/node · GitHub

/ node Public

src: use forward declaration instead of include - #30159

Closed
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:reduceCompiletimeDeps
Closed

src: use forward declaration instead of include#30159
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:reduceCompiletimeDeps

Conversation

fhinkel commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

Reduce number of includes in header file to reduce build time.

Reduce number of includes in header file to reduce build time.
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Oct 29, 2019

Copy link
Copy Markdown
Member

I think this is already covered by #30133?

fhinkel commented Oct 29, 2019

Copy link
Copy Markdown
Contributor Author

I think this is already covered by #30133?

You're right. Somehow I thought that PR doesn't cover stat_watcher. Sorry for the noise.

fhinkel closed this Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL