FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: use contact_links instead of issue templates by targos · Pull Request #30172 · nodejs/node · GitHub

/ node Public

meta: use contact_links instead of issue templates - #30172

Closed
targos wants to merge 2 commits into
nodejs:masterfrom
targos:github-issue-config
ConversationCommits (2)ChecksFiles changed
Closed

meta: use contact_links instead of issue templates#30172
targos wants to merge 2 commits into
nodejs:masterfrom
targos:github-issue-config

Conversation

targos commented Oct 30, 2019

Copy link
Copy Markdown
Member

meta: use contact_links instead of issue templates
e7f6119 
To redirect people to the help and website repos.
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 30, 2019
addaleax approved these changes Oct 30, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

tniessen approved these changes Oct 30, 2019
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
sam-github reviewed Oct 30, 2019
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/config.yml
@@ -0,0 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: ⁉️ Need help with Node.js?

sam-github Oct 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is the leading !? intended? It looks like a typo.

targos Oct 30, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is an emoji. See https://github.com/targos/node/issues/new/choose

sam-github Oct 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't see an emoji, I see the literal text ⁉️ Need help with Node.js? on the choose site, same as the text above.

I notice its the same at https://github.com/nodejs/node/issues/new/choose though, so its pre-existing, unrelated to this PR.

Update .github/ISSUE_TEMPLATE/config.yml
1db9995 
Co-Authored-By: Tobias Nießen <tniessen@users.noreply.github.com>

targos commented Nov 1, 2019

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4026/

targos commented Nov 1, 2019

Copy link
Copy Markdown
Member Author

Landed in 75dc893

targos closed this Nov 1, 2019
targos added a commit that referenced this pull request Nov 1, 2019
meta: use contact_links instead of issue templates
75dc893 
To redirect people to the help and website repos.

PR-URL: #30172
Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos deleted the github-issue-config branch November 1, 2019 15:01
targos added a commit that referenced this pull request Nov 5, 2019
meta: use contact_links instead of issue templates
050efeb 
To redirect people to the help and website repos.

PR-URL: #30172
Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos mentioned this pull request Nov 5, 2019
Merged
targos added a commit that referenced this pull request Nov 8, 2019
meta: use contact_links instead of issue templates
ad4f4f1 
To redirect people to the help and website repos.

PR-URL: #30172
Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
meta: use contact_links instead of issue templates
9003881 
To redirect people to the help and website repos.

PR-URL: #30172
Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
meta: use contact_links instead of issue templates
d8f43f6 
To redirect people to the help and website repos.

PR-URL: #30172
Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos mentioned this pull request Nov 10, 2019
Merged
targos added a commit that referenced this pull request Nov 11, 2019
meta: use contact_links instead of issue templates
b0837fe 
To redirect people to the help and website repos.

PR-URL: #30172
Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
BethGriggs BethGriggs approved these changes
trivikr trivikr approved these changes
+2 more reviewers
sam-github sam-github left review comments
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL