build: allow Python 3.8 - #30194
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cclauss
approved these changes
Oct 31, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Oct 31, 2019
Comment thread
configure
| # pyenv will alert which shims are available and then will fail the build. | ||
| _=[ 'exec' '/bin/sh' '-c' ''' | ||
| test ${TRAVIS} && exec python "$0" "$@" # workaround for pyenv on Travis CI | ||
| which python3.8 >/dev/null && exec python3.8 "$0" "$@" |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should we maybe check for python3 first?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The trouble with doing that is that python3 might be in ((3, 0), (3, 1), (3, 2), (3, 3), (3, 4)) which we (and the Python Core Team) do not support.
Sorry, something went wrong.
devnexen
approved these changes
Oct 31, 2019
trivikr
approved these changes
Oct 31, 2019
Copy link
Copy Markdown
Contributor
|
I'm fine with this, but I wonder if we should be so specific, can't we just say 3.5 and above? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Explicit is better than implicit is line 2 of The Zen of Python written in 2004. |
Sorry, something went wrong.
lpinca
approved these changes
Oct 31, 2019
richardlau
approved these changes
Oct 31, 2019
gengjiawen
approved these changes
Nov 1, 2019
cclauss
pushed a commit
that referenced
this pull request
Nov 2, 2019
PR-URL: #30194 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
63 tasks
targos
added a commit
that referenced
this pull request
Nov 5, 2019
PR-URL: #30194 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Windows.
/cc @nodejs/python @cclauss