tools: fix Python 3 deprecation warning in test.py - #30208
Closed
Hellzed wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cclauss
approved these changes
Nov 1, 2019
cclauss
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Beautiful! Thanks much.
Sorry, something went wrong.
addaleax
approved these changes
Nov 1, 2019
targos
approved these changes
Nov 1, 2019
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks a lot!
nit: indentation should be two spaces
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
If you want GitHub to register your contribution, you need to add the email address used for the commit to your account (at https://github.com/settings/emails) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
fixed! |
Sorry, something went wrong.
devnexen
approved these changes
Nov 1, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cclauss
pushed a commit
that referenced
this pull request
Nov 3, 2019
PR-URL: #30208 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 5, 2019
PR-URL: #30208 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
63 tasks
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
PR-URL: #30208 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
PR-URL: #30208 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
PR-URL: #30208 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2019
PR-URL: #30208 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Python 3.4, the imp module is deprecated, causing a deprecation warning when running tools/test.py.
This fixes it by conditionally using importlib instead when running tools/test.py with Python 3.5+.
Notes:
Checklist