tools: make doctool work if no internet available - #30214
Merged
richardlau merged 1 commit intoNov 6, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
force-pushed
the
nointernetdoctests
branch
from
a3d45c1 to
3cb0fed
Compare
November 2, 2019 08:53
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
reviewed
Nov 2, 2019
Comment thread
tools/doc/versions.js
Outdated
Trott
approved these changes
Nov 3, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
force-pushed
the
nointernetdoctests
branch
3 times, most recently
from
7d2a1b6 to
3ce1da5
Compare
November 3, 2019 22:05
devsnek
approved these changes
Nov 3, 2019
Copy link
Copy Markdown
Member
Author
|
ARM builds currently have issues unrelated to this PR (nodejs/build#2028) so holding off rerunning CI until they're resolved. |
Sorry, something went wrong.
legendecas
approved these changes
Nov 4, 2019
joyeecheung
approved these changes
Nov 4, 2019
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
BridgeAR
approved these changes
Nov 5, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gengjiawen
approved these changes
Nov 6, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: nodejs#30214 Fixes: nodejs#29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
richardlau
force-pushed
the
nointernetdoctests
branch
from
3ce1da5 to
3b124e0
Compare
November 6, 2019 03:12
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214 Fixes: #29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214 Fixes: #29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214 Fixes: #29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
3 tasks
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Apr 6, 2020
Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: nodejs#32642 PR-URL: nodejs#30214 Fixes: nodejs#29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 6, 2020
Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: #32642 PR-URL: #30214 Fixes: #29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow doctool to fallback to use local files if not building a release
build.
Fixes: #29918
cc @joyeecheung
Checklist