process: make source map getter resistant against prototype tampering - #30228
Closed
addaleax wants to merge 3 commits into
Closed
process: make source map getter resistant against prototype tampering#30228addaleax wants to merge 3 commits into
addaleax wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of `worker.terminate()`.
3 tasks
devsnek
reviewed
Nov 2, 2019
Comment thread
lib/internal/source_map/source_map_cache.js
Outdated
targos
reviewed
Nov 2, 2019
Comment thread
lib/internal/source_map/source_map_cache.js
Outdated
joyeecheung
approved these changes
Nov 3, 2019
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM % a nit
Sorry, something went wrong.
Comment thread
lib/internal/source_map/source_map_cache.js
Outdated
bcoe
approved these changes
Nov 4, 2019
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this looks reasonable to me, you tested the earlier example you shared with me:
const builtInForEach = Array.prototype.forEach;
Array.prototype.forEach = function(...args) {
process._rawDebug('ran JS after being terminated at', new Error().stack);
return builtInForEach.call(this, ...args);
}
Sorry, something went wrong.
Comment thread
lib/internal/source_map/source_map_cache.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Nov 4, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Nov 5, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
added a commit
that referenced
this pull request
Nov 5, 2019
Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of `worker.terminate()`. PR-URL: #30228 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of `worker.terminate()`. PR-URL: #30228 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of `worker.terminate()`. PR-URL: #30228 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of `worker.terminate()`. PR-URL: #30228 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this code runs during process and Worker shutdown, it should not
call user-provided code and thereby e.g. provide a way to break out of
worker.terminate().
Checklist