cluster: destruct primordials in lib/internal/cluster/worker.js - #30246
Closed
peze wants to merge 1 commit into
Closed
cluster: destruct primordials in lib/internal/cluster/worker.js#30246peze wants to merge 1 commit into
peze wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gireeshpunathil
approved these changes
Nov 4, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
XadillaX
approved these changes
Nov 4, 2019
XadillaX
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM if CI is ok.
Sorry, something went wrong.
ZYSzys
approved these changes
Nov 4, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Nov 4, 2019
gengjiawen
approved these changes
Nov 4, 2019
cjihrig
approved these changes
Nov 4, 2019
BridgeAR
approved these changes
Nov 5, 2019
ZYSzys
pushed a commit
that referenced
this pull request
Nov 9, 2019
Refs: nodejs/code-and-learn#97 PR-URL: #30246 Refs: nodejs/code-and-learn#97 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Member
|
Landed in 0356746. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Refs: nodejs/code-and-learn#97 PR-URL: #30246 Refs: nodejs/code-and-learn#97 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Refs: nodejs/code-and-learn#97 PR-URL: #30246 Refs: nodejs/code-and-learn#97 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Refs: nodejs/code-and-learn#97 PR-URL: #30246 Refs: nodejs/code-and-learn#97 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/code-and-learn#97
Checklist