FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "test: test configure ninja" by addaleax · Pull Request #30295 · nodejs/node · GitHub

/ node Public

Revert "test: test configure ninja" - #30295

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:revert-30033
ConversationCommits (1)ChecksFiles changed
Closed

Revert "test: test configure ninja"#30295
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:revert-30033

Conversation

addaleax commented Nov 6, 2019

Copy link
Copy Markdown
Member

This reverts commit 85dd9e8.

make test should never change the current set of configure
flags.

Refs: #30033

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Revert "test: test configure ninja"
87aac3f 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: nodejs#30033
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 6, 2019

addaleax commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

Please 👍 this comment to approve fast-tracking, even without a full CI run.

This currently breaks ./configure with flags other than --ninja and makes the full Node.js build run twice (once without ninja, once with) when e.g. compiling addon tests.

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2019

nodejs-github-bot commented Nov 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26401/

addaleax commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

Landed in 3698031, thanks for the quick reviews!

addaleax closed this Nov 6, 2019
addaleax added a commit that referenced this pull request Nov 6, 2019
Revert "test: test configure ninja"
3698031 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
addaleax deleted the revert-30033 branch November 6, 2019 11:46
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
Revert "test: test configure ninja"
8fe6849 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BridgeAR mentioned this pull request Nov 19, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL